2015-05-06 11:27:27

by Daniel Wagner

[permalink] [raw]
Subject: ov2659: "error: implicit declaration of f unction ‘v4l2_subdev_get_try_format’"

Hi,

I got this doing a randconfig on v4.1-rc2

CC [M] drivers/media/i2c/ov2659.o
drivers/media/i2c/ov2659.c: In function ‘ov2659_get_fmt’:
drivers/media/i2c/ov2659.c:1054:3: error: implicit declaration of function ‘v4l2_subdev_get_try_format’ [-Werror=implicit-function-declaration]
mf = v4l2_subdev_get_try_format(sd, cfg, 0);
^
drivers/media/i2c/ov2659.c:1054:6: warning: assignment makes pointer from integer without a cast
mf = v4l2_subdev_get_try_format(sd, cfg, 0);
^
drivers/media/i2c/ov2659.c: In function ‘ov2659_set_fmt’:
drivers/media/i2c/ov2659.c:1129:6: warning: assignment makes pointer from integer without a cast
mf = v4l2_subdev_get_try_format(sd, cfg, fmt->pad);
^
drivers/media/i2c/ov2659.c: In function ‘ov2659_open’:
drivers/media/i2c/ov2659.c:1264:38: error: ‘struct v4l2_subdev_fh’ has no member named ‘pad’
v4l2_subdev_get_try_format(sd, fh->pad, 0);
^


cheers,
daniel


Attachments:
config (86.58 kB)

2015-05-06 11:54:34

by Daniel Wagner

[permalink] [raw]
Subject: Re: ov2659: "error: implicit declaration of function ‘v4l2_subdev_get_try_format’"


On 05/06/2015 01:27 PM, Daniel Wagner wrote:
> Hi,
>
> I got this doing a randconfig on v4.1-rc2

Since this hits me all the time I did following hack which is probably
completely stupid but hey it works :)

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 6f30ea7..8b05681 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -468,7 +468,7 @@ config VIDEO_SMIAPP_PLL

config VIDEO_OV2659
tristate "OmniVision OV2659 sensor support"
- depends on VIDEO_V4L2 && I2C
+ depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
depends on MEDIA_CAMERA_SUPPORT
---help---
This is a Video4Linux2 sensor-level driver for the OmniVision