2015-05-14 12:41:56

by Tomeu Vizoso

[permalink] [raw]
Subject: [PATCH v2] ARM: dts: Add syscon property to the MIPI phy in exynos5420

Since e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by
adding support for PMU regmap") the syscon property is required in
samsung,s5pv210-mipi-video-phy nodes, but this DTS hadn't been updated
yet.

Signed-off-by: Tomeu Vizoso <[email protected]>
Reviewed-by: Javier Martinez Canillas <[email protected]>
Cc: Sylwester Nawrocki <[email protected]>
Cc: Krzysztof Kozłowski <[email protected]>

--

v2: * Remove reg property as suggested by Javier
* Added his Reviewed-by
---
arch/arm/boot/dts/exynos5420.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 4531753..78bcbc0 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -541,7 +541,7 @@

mipi_phy: video-phy@10040714 {
compatible = "samsung,s5pv210-mipi-video-phy";
- reg = <0x10040714 12>;
+ syscon = <&pmu_system_controller>;
#phy-cells = <1>;
};

--
2.4.0


2015-05-15 13:22:43

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2] ARM: dts: Add syscon property to the MIPI phy in exynos5420

2015-05-14 21:40 GMT+09:00 Tomeu Vizoso <[email protected]>:
> Since e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by
> adding support for PMU regmap") the syscon property is required in
> samsung,s5pv210-mipi-video-phy nodes, but this DTS hadn't been updated
> yet.
>
> Signed-off-by: Tomeu Vizoso <[email protected]>
> Reviewed-by: Javier Martinez Canillas <[email protected]>
> Cc: Sylwester Nawrocki <[email protected]>
> Cc: Krzysztof Kozłowski <[email protected]>
>
> --

Triple-dash please, because this won't be cut by "git am".

Everything else looks fine, thank you.
Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2015-05-16 03:27:41

by Kukjin Kim

[permalink] [raw]
Subject: Re: [PATCH v2] ARM: dts: Add syscon property to the MIPI phy in exynos5420

On 05/15/15 22:22, Krzysztof Kozlowski wrote:
> 2015-05-14 21:40 GMT+09:00 Tomeu Vizoso <[email protected]>:
>> Since e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by
>> adding support for PMU regmap") the syscon property is required in
>> samsung,s5pv210-mipi-video-phy nodes, but this DTS hadn't been updated
>> yet.
>>
>> Signed-off-by: Tomeu Vizoso <[email protected]>
>> Reviewed-by: Javier Martinez Canillas <[email protected]>
>> Cc: Sylwester Nawrocki <[email protected]>
>> Cc: Krzysztof Kozłowski <[email protected]>
>>
>> --
>
> Triple-dash please, because this won't be cut by "git am".
>
> Everything else looks fine, thank you.
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
Applied, thanks for you guys' effort.

- Kukjin