2015-06-20 16:41:36

by Manfred Schlaegl

Subject: [PATCH] serial: imx: count tty buffer overruns

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

As can be seen in function uart_insert_char (serial_core) the element
buf_overrun of struct uart_icount is used to count overruns of
tty-buffer.
Added support for counting of overruns in imx driver analogue to
serial_core.

Signed-off-by: Manfred Schlaegl <[email protected]>
- ---
drivers/tty/serial/imx.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 8825039..384cf1d 100644
- --- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -700,7 +700,8 @@ static irqreturn_t imx_rxint(int irq, void *dev_id)
if (sport->port.ignore_status_mask & URXD_DUMMY_READ)
goto out;
- tty_insert_flip_char(port, rx, flg);
+ if (tty_insert_flip_char(port, rx, flg) == 0)
+ sport->port.icount.buf_overrun++;
}
out:
@@ -922,8 +923,13 @@ static void dma_rx_callback(void *data)
dev_dbg(sport->port.dev, "We get %d bytes.\n", count);
if (count) {
- - if (!(sport->port.ignore_status_mask & URXD_DUMMY_READ))
- - tty_insert_flip_string(port, sport->rx_buf, count);
+ if (!(sport->port.ignore_status_mask & URXD_DUMMY_READ)) {
+ int bytes = tty_insert_flip_string(port, sport->rx_buf,
+ count);
+
+ if (bytes != count)
+ sport->port.icount.buf_overrun++;
+ }
tty_flip_buffer_push(port);
start_rx_dma(sport);
- --
1.7.10.4

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJVhZevAAoJEGS1eKPM78WhYlIP/1xUn8g37afejHntKdRgYOGZ
V5izKDvCWNNxIIWQ3Rw1NtN9+695LO4WsZX7n4FYzBQbZHE8F5bzVM9bGnSJOjie
4imHKaGrzWhHy9uP/Z6j6aGqdqGHD6QtxcJ6A0u4A8CrYbUZKjEXk0YUH8BPawb4
8oKwm8Gn4N+ispHL9SDtV+q4yoOZApd6OcXdIpxrtKSunHWuSigJ66Fs7416liuh
D90q4zEENvfdMqpBf5w5IxYUkhQHDCzE3NAgVUCeOqnFa84daq+H51GPEsbFdGlo
MsFsu/qU0lQ1S+EnkbSoFQ/519ujMhi0pdxvcgHlijEFtLUmibh1jvIYdsw9et0o
v3Xp5xGro7r9GOUhjiiTazVR0jPCt+owjAc/7PPiiBqaToeSeiSa7sJk8FBSkMPF
sr2/4UStomLVZgnm/KY2O+HTTyw2insH7iVxJeHf7ZBEeQeRL+jgn2cgeyE8e8Vt
x8jYXPhwYnWWh4C6wC1lidlCLfgDZGQI6DnnyTb2W7DEHNwGXJHPTA3N/liz5Kox
LxNA5KA/l0gzsRZdv9iCuJVlxAWHBH5/wRE4+ojurNcyI5gGcOaiLzGqYc5QL7gz
1ODtX0RoP1guMkq6w1LSBSIWVIGXoFn8AcWkdDgpqBp0jXWo5s2ivGXaa3OKX80y
NMGTG7+2PxXQ9aPtk3gv
=BuFt
-----END PGP SIGNATURE-----

2015-06-20 16:57:27

by Greg Kroah-Hartman

Subject: Re: [PATCH] serial: imx: count tty buffer overruns

On Sat, Jun 20, 2015 at 06:41:20PM +0200, [email protected] wrote:
> As can be seen in function uart_insert_char (serial_core) the element
> buf_overrun of struct uart_icount is used to count overruns of
> tty-buffer.
> Added support for counting of overruns in imx driver analogue to
> serial_core.
>
> Signed-off-by: Manfred Schlaegl <[email protected]>

Your From: line in your email doesn't match this, please fix up and
resend.

Same goes for your other serial patch.

thanks,

greg k-h

2015-06-20 17:17:21

by Manfred Schlaegl

Subject: Re: [PATCH] serial: imx: count tty buffer overruns

On 2015-06-20 18:57, Greg Kroah-Hartman wrote:
> On Sat, Jun 20, 2015 at 06:41:20PM +0200, [email protected] wrote:
>> As can be seen in function uart_insert_char (serial_core) the element
>> buf_overrun of struct uart_icount is used to count overruns of
>> tty-buffer.
>> Added support for counting of overruns in imx driver analogue to
>> serial_core.
>>
>> Signed-off-by: Manfred Schlaegl <[email protected]>
>
> Your From: line in your email doesn't match this, please fix up and
> resend.
>
> Same goes for your other serial patch.
>
> thanks,
>
> greg k-h
>

Hi!

Argh.. Sorry for the mess ..
The patch format was also not ok. I was working on a newly setup system.
I'll resend soon.

best regards,
manfred