2015-07-08 05:19:49

by Vaishali Thakkar

Subject: [PATCH] net: systemport: Use eth_hw_addr_random

Use eth_hw_addr_random() instead of calling random_ether_addr().
Here, this change is setting addr_assign_type to NET_ADDR_RANDOM.

The Coccinelle semantic patch that performs this transformation
is as follows:

@@
identifier a,b;
@@

-random_ether_addr(a->b);
+eth_hw_addr_random(a);

Signed-off-by: Vaishali Thakkar <[email protected]>
---
Note that this patch is compile tested only and I have used file
drivers/net/ethernet/hisilicon/hix5hd2_gmac.c as a reference.
Also, original call didn't make assignment to NET_ADDR_RANDOM. So,
it would be good if someone can test this change.
---
drivers/net/ethernet/broadcom/bcmsysport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index 909ad7a..4566cdf 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -1793,7 +1793,7 @@ static int bcm_sysport_probe(struct platform_device *pdev)
macaddr = of_get_mac_address(dn);
if (!macaddr || !is_valid_ether_addr(macaddr)) {
dev_warn(&pdev->dev, "using random Ethernet MAC\n");
- random_ether_addr(dev->dev_addr);
+ eth_hw_addr_random(dev);
} else {
ether_addr_copy(dev->dev_addr, macaddr);
}
--
1.9.1

2015-07-09 05:02:12

by Florian Fainelli

Subject: Re: [PATCH] net: systemport: Use eth_hw_addr_random

Le 07/07/15 22:19, Vaishali Thakkar a écrit :
> Use eth_hw_addr_random() instead of calling random_ether_addr().
> Here, this change is setting addr_assign_type to NET_ADDR_RANDOM.
>
> The Coccinelle semantic patch that performs this transformation
> is as follows:
>
> @@
> identifier a,b;
> @@
>
> -random_ether_addr(a->b);
> +eth_hw_addr_random(a);
>
> Signed-off-by: Vaishali Thakkar <[email protected]>
> ---
> Note that this patch is compile tested only and I have used file
> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c as a reference.
> Also, original call didn't make assignment to NET_ADDR_RANDOM. So,
> it would be good if someone can test this change.

Thanks, I will give this a try and report.

> ---
> drivers/net/ethernet/broadcom/bcmsysport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
> index 909ad7a..4566cdf 100644
> --- a/drivers/net/ethernet/broadcom/bcmsysport.c
> +++ b/drivers/net/ethernet/broadcom/bcmsysport.c
> @@ -1793,7 +1793,7 @@ static int bcm_sysport_probe(struct platform_device *pdev)
> macaddr = of_get_mac_address(dn);
> if (!macaddr || !is_valid_ether_addr(macaddr)) {
> dev_warn(&pdev->dev, "using random Ethernet MAC\n");
> - random_ether_addr(dev->dev_addr);
> + eth_hw_addr_random(dev);
> } else {
> ether_addr_copy(dev->dev_addr, macaddr);
> }
>


--
Florian

2015-07-09 21:33:06

by Florian Fainelli

Subject: Re: [PATCH] net: systemport: Use eth_hw_addr_random

On 07/07/15 22:19, Vaishali Thakkar wrote:
> Use eth_hw_addr_random() instead of calling random_ether_addr().
> Here, this change is setting addr_assign_type to NET_ADDR_RANDOM.
>
> The Coccinelle semantic patch that performs this transformation
> is as follows:
>
> @@
> identifier a,b;
> @@
>
> -random_ether_addr(a->b);
> +eth_hw_addr_random(a);
>
> Signed-off-by: Vaishali Thakkar <[email protected]>

Tested-by: Florian Fainelli <[email protected]>
Reviewed-by: Florian Fainelli <[email protected]>

> ---
> Note that this patch is compile tested only and I have used file
> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c as a reference.
> Also, original call didn't make assignment to NET_ADDR_RANDOM. So,
> it would be good if someone can test this change.
> ---
> drivers/net/ethernet/broadcom/bcmsysport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
> index 909ad7a..4566cdf 100644
> --- a/drivers/net/ethernet/broadcom/bcmsysport.c
> +++ b/drivers/net/ethernet/broadcom/bcmsysport.c
> @@ -1793,7 +1793,7 @@ static int bcm_sysport_probe(struct platform_device *pdev)
> macaddr = of_get_mac_address(dn);
> if (!macaddr || !is_valid_ether_addr(macaddr)) {
> dev_warn(&pdev->dev, "using random Ethernet MAC\n");
> - random_ether_addr(dev->dev_addr);
> + eth_hw_addr_random(dev);
> } else {
> ether_addr_copy(dev->dev_addr, macaddr);
> }
>


--
Florian

2015-07-09 21:51:51

by David Miller

Subject: Re: [PATCH] net: systemport: Use eth_hw_addr_random

From: Vaishali Thakkar <[email protected]>
Date: Wed, 8 Jul 2015 10:49:30 +0530

> Use eth_hw_addr_random() instead of calling random_ether_addr().
> Here, this change is setting addr_assign_type to NET_ADDR_RANDOM.
>
> The Coccinelle semantic patch that performs this transformation
> is as follows:
>
> @@
> identifier a,b;
> @@
>
> -random_ether_addr(a->b);
> +eth_hw_addr_random(a);
>
> Signed-off-by: Vaishali Thakkar <[email protected]>

Applied, thanks.