2022-08-24 09:44:20

by Yang Yingliang

Subject: [PATCH -next] parisc: ccio-dma: Add missing iounmap in error path in ccio_probe()

Add missing iounmap() before return from ccio_probe(), if ccio_init_resources()
fails.

Fixes: d46c742f827f ("parisc: ccio-dma: Handle kmalloc failure in ccio_init_resources()")
Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/parisc/ccio-dma.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c
index f223afe47d10..a66386043aa6 100644
--- a/drivers/parisc/ccio-dma.c
+++ b/drivers/parisc/ccio-dma.c
@@ -1546,6 +1546,7 @@ static int __init ccio_probe(struct parisc_device *dev)
}
ccio_ioc_init(ioc);
if (ccio_init_resources(ioc)) {
+ iounmap(ioc->ioc_regs);
kfree(ioc);
return -ENOMEM;
}
--
2.25.1

2022-08-24 19:36:19

by Helge Deller

Subject: Re: [PATCH -next] parisc: ccio-dma: Add missing iounmap in error path in ccio_probe()

On 8/24/22 11:36, Yang Yingliang wrote:
> Add missing iounmap() before return from ccio_probe(), if ccio_init_resources()
> fails.
>
> Fixes: d46c742f827f ("parisc: ccio-dma: Handle kmalloc failure in ccio_init_resources()")
> Signed-off-by: Yang Yingliang <[email protected]>

applied.
Thanks!
Helge


> ---
> drivers/parisc/ccio-dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c
> index f223afe47d10..a66386043aa6 100644
> --- a/drivers/parisc/ccio-dma.c
> +++ b/drivers/parisc/ccio-dma.c
> @@ -1546,6 +1546,7 @@ static int __init ccio_probe(struct parisc_device *dev)
> }
> ccio_ioc_init(ioc);
> if (ccio_init_resources(ioc)) {
> + iounmap(ioc->ioc_regs);
> kfree(ioc);
> return -ENOMEM;
> }