2015-07-16 19:35:15

by Colin King

Subject: [PATCH] xen: fix non-ANSI function declaration of function xen_has_pv_devices

From: Colin Ian King <[email protected]>

xen_has_pv_devices has no parameters, so use the normal void
parameter convention to make it match the prototype in the
header file include/xen/platform_pci.h

Signed-off-by: Colin Ian King <[email protected]>
---
arch/x86/xen/platform-pci-unplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/xen/platform-pci-unplug.c b/arch/x86/xen/platform-pci-unplug.c
index a826171..9586ff3 100644
--- a/arch/x86/xen/platform-pci-unplug.c
+++ b/arch/x86/xen/platform-pci-unplug.c
@@ -68,7 +68,7 @@ static int check_platform_magic(void)
return 0;
}

-bool xen_has_pv_devices()
+bool xen_has_pv_devices(void)
{
if (!xen_domain())
return false;
--
2.1.4

2015-07-16 19:35:17

by Colin King

Subject: [PATCH] xen: fix non-ANSI function declaration of function xen_has_pv_devices

From: Colin Ian King <[email protected]>

xen_has_pv_devices has no parameters, so use the normal void
parameter convention to make it match the prototype in the
header file include/xen/platform_pci.h

Signed-off-by: Colin Ian King <[email protected]>
---
arch/x86/xen/platform-pci-unplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/xen/platform-pci-unplug.c b/arch/x86/xen/platform-pci-unplug.c
index a826171..9586ff3 100644
--- a/arch/x86/xen/platform-pci-unplug.c
+++ b/arch/x86/xen/platform-pci-unplug.c
@@ -68,7 +68,7 @@ static int check_platform_magic(void)
return 0;
}

-bool xen_has_pv_devices()
+bool xen_has_pv_devices(void)
{
if (!xen_domain())
return false;
--
2.1.4

2015-07-20 13:28:19

by David Vrabel

Subject: Re: [Xen-devel] [PATCH] xen: fix non-ANSI function declaration of function xen_has_pv_devices

On 16/07/15 20:34, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> xen_has_pv_devices has no parameters, so use the normal void
> parameter convention to make it match the prototype in the
> header file include/xen/platform_pci.h

Applied to for-linus-4.3, thanks.

David