On 26.10.2015 21:55, Pankaj Dubey wrote:
> This patch series is a part of continuation work from following series
> [1] and [2].
>
> 1: exynos: Move pmu driver to driver/soc folder and add exynos7 support
> http://www.spinics.net/lists/linux-samsung-soc/msg39797.html from Amit Daniel Kacchap
> 2: soc: samsung: pmu: split up SoC specific PMU data
> https://lkml.org/lkml/2015/1/7/12 from me
>
+Cc Bartlomiej,
There were some concerns for previous versions of this patchset. I
cannot find all of them (e.g. Bartlomiej's are not present on lkml.org
anymore) so I am not sure if they were addressed properly.
I like the approach, it helps in reviewing the patch.
I wonder - after adding this for ARM64 how much of duplicated code this
approach reduce?
Best regards,
Krzysztof
> Here is another attempt for the same, in this series I am splitting up SoC
> specific PMU configuration data into mach-exynos folder itself, before moving
> all of them under drivers/soc/samsung/. Also instead of making all changes in
> single patch it has been broken into SoC specific patches to avoid large size
> of patch. With this approach there will not be unwanted big churns just after
> adding exynos-pmu under drivers/soc/samsung.
>
> All these patches are just refactoring to keep minimal changes while moving
> exynos-pmu driver under drivers/soc/samsung/. Support for exynos7 PMU can be added
> on top of it, in such a manner that for ARM64 build, ARM related SoC's PMU will not
> get compiled and thus unnecessary increasing kernel image size.
>
> I have tested on Peach-Pi (Exynos5880) based chromebook for boot
> and S2R functionality.
>
> These patches have been prepared on top of Kukjin Kim's for-next
>
> Changes since v2:
> - Removed Amit's Samsung id as it's no more valid.
> - Rebased on latest kgene tree.
> - Removed redundant code from regs-pmu.h
>
>
> Pankaj Dubey (7):
> ARM: EXYNOS: removing redundant code from regs-pmu.h
> ARM: EXYNOS: Move pmu specific headers under "linux/soc/samsung"
> ARCH: EXYNOS: split up exynos3250 SoC specific PMU data
> ARCH: EXYNOS: split up exynos4 SoC specific PMU data
> ARCH: EXYNOS: split up exynos5250 SoC specific PMU data
> ARCH: EXYNOS: split up exynos5420 SoC specific PMU data
> drivers: soc: Add support for Exynos PMU driver
>
> arch/arm/mach-exynos/Kconfig | 1 +
> arch/arm/mach-exynos/Makefile | 2 +-
> arch/arm/mach-exynos/exynos.c | 2 +-
> arch/arm/mach-exynos/mcpm-exynos.c | 2 +-
> arch/arm/mach-exynos/platsmp.c | 2 +-
> arch/arm/mach-exynos/pm.c | 4 +-
> arch/arm/mach-exynos/pmu.c | 1004 --------------------
> arch/arm/mach-exynos/suspend.c | 4 +-
> drivers/soc/samsung/Kconfig | 4 +
> drivers/soc/samsung/Makefile | 4 +
> drivers/soc/samsung/exynos-pmu.c | 168 ++++
> drivers/soc/samsung/exynos-pmu.h | 52 +
> drivers/soc/samsung/exynos3250-pmu.c | 175 ++++
> drivers/soc/samsung/exynos4-pmu.c | 223 +++++
> drivers/soc/samsung/exynos5250-pmu.c | 196 ++++
> drivers/soc/samsung/exynos5420-pmu.c | 280 ++++++
> .../linux/soc/samsung}/exynos-pmu.h | 2 +-
> .../linux/soc/samsung/exynos-regs-pmu.h | 17 +-
> 18 files changed, 1116 insertions(+), 1026 deletions(-)
> delete mode 100644 arch/arm/mach-exynos/pmu.c
> create mode 100644 drivers/soc/samsung/exynos-pmu.c
> create mode 100644 drivers/soc/samsung/exynos-pmu.h
> create mode 100644 drivers/soc/samsung/exynos3250-pmu.c
> create mode 100644 drivers/soc/samsung/exynos4-pmu.c
> create mode 100644 drivers/soc/samsung/exynos5250-pmu.c
> create mode 100644 drivers/soc/samsung/exynos5420-pmu.c
> rename {arch/arm/mach-exynos => include/linux/soc/samsung}/exynos-pmu.h (90%)
> rename arch/arm/mach-exynos/regs-pmu.h => include/linux/soc/samsung/exynos-regs-pmu.h (98%)
>
Hi Krzysztof,
On Tuesday 03 November 2015 07:36 AM, Krzysztof Kozlowski wrote:
> On 26.10.2015 21:55, Pankaj Dubey wrote:
>> This patch series is a part of continuation work from following series
>> [1] and [2].
>>
>> 1: exynos: Move pmu driver to driver/soc folder and add exynos7 support
>> http://www.spinics.net/lists/linux-samsung-soc/msg39797.html from Amit Daniel Kacchap
>> 2: soc: samsung: pmu: split up SoC specific PMU data
>> https://lkml.org/lkml/2015/1/7/12 from me
>>
>
> +Cc Bartlomiej,
>
> There were some concerns for previous versions of this patchset. I
> cannot find all of them (e.g. Bartlomiej's are not present on lkml.org
> anymore) so I am not sure if they were addressed properly.
>
Yes. If I recall correctly he has following main concerns:
1: To convert exynos-pmu to a proper platform driver before moving out
of arch/arm/mach-exynos. This is already addressed.
2: Do we really need common driver for both ARM and ARM64? I feel yes,
as at least I can see that driver's basic structure will be reused. As
in case of PMU driver most of lines of code is data part (register
offset and its values in different mode), that part will be kept in
separate file e.g. exynos7-pmu.c or exynosXXXX-pmu.c.
There has been already one attempt of submission for exynos7 PMU driver at:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/305418.html
3: He had a concern that in case of ARM64 build most of ARM related code
will be present in binary which will be dead code, that can be addressed
by excluding ARM based SoC exynosXXXX-pmu.c file in Makefile.
It has been taken care in v3 7/7 patch in drivers/soc/samsung/Makefile.
> I like the approach, it helps in reviewing the patch.
Thanks. This was a review comment from Kukjin, to separate data part of
all SoC and move them to respective files, same as we do for clock files
of each SoC.
>
> I wonder - after adding this for ARM64 how much of duplicated code this
> approach reduce?
>
It will reduce in duplication driver structure, which will be same.
> Best regards,
> Krzysztof
>
>> Here is another attempt for the same, in this series I am splitting up SoC
>> specific PMU configuration data into mach-exynos folder itself, before moving
>> all of them under drivers/soc/samsung/. Also instead of making all changes in
>> single patch it has been broken into SoC specific patches to avoid large size
>> of patch. With this approach there will not be unwanted big churns just after
>> adding exynos-pmu under drivers/soc/samsung.
>>
>> All these patches are just refactoring to keep minimal changes while moving
>> exynos-pmu driver under drivers/soc/samsung/. Support for exynos7 PMU can be added
>> on top of it, in such a manner that for ARM64 build, ARM related SoC's PMU will not
>> get compiled and thus unnecessary increasing kernel image size.
>>
>> I have tested on Peach-Pi (Exynos5880) based chromebook for boot
>> and S2R functionality.
>>
>> These patches have been prepared on top of Kukjin Kim's for-next
>>
>> Changes since v2:
>> - Removed Amit's Samsung id as it's no more valid.
>> - Rebased on latest kgene tree.
>> - Removed redundant code from regs-pmu.h
>>
>>
>> Pankaj Dubey (7):
>> ARM: EXYNOS: removing redundant code from regs-pmu.h
>> ARM: EXYNOS: Move pmu specific headers under "linux/soc/samsung"
>> ARCH: EXYNOS: split up exynos3250 SoC specific PMU data
>> ARCH: EXYNOS: split up exynos4 SoC specific PMU data
>> ARCH: EXYNOS: split up exynos5250 SoC specific PMU data
>> ARCH: EXYNOS: split up exynos5420 SoC specific PMU data
>> drivers: soc: Add support for Exynos PMU driver
>>
>> arch/arm/mach-exynos/Kconfig | 1 +
>> arch/arm/mach-exynos/Makefile | 2 +-
>> arch/arm/mach-exynos/exynos.c | 2 +-
>> arch/arm/mach-exynos/mcpm-exynos.c | 2 +-
>> arch/arm/mach-exynos/platsmp.c | 2 +-
>> arch/arm/mach-exynos/pm.c | 4 +-
>> arch/arm/mach-exynos/pmu.c | 1004 --------------------
>> arch/arm/mach-exynos/suspend.c | 4 +-
>> drivers/soc/samsung/Kconfig | 4 +
>> drivers/soc/samsung/Makefile | 4 +
>> drivers/soc/samsung/exynos-pmu.c | 168 ++++
>> drivers/soc/samsung/exynos-pmu.h | 52 +
>> drivers/soc/samsung/exynos3250-pmu.c | 175 ++++
>> drivers/soc/samsung/exynos4-pmu.c | 223 +++++
>> drivers/soc/samsung/exynos5250-pmu.c | 196 ++++
>> drivers/soc/samsung/exynos5420-pmu.c | 280 ++++++
>> .../linux/soc/samsung}/exynos-pmu.h | 2 +-
>> .../linux/soc/samsung/exynos-regs-pmu.h | 17 +-
>> 18 files changed, 1116 insertions(+), 1026 deletions(-)
>> delete mode 100644 arch/arm/mach-exynos/pmu.c
>> create mode 100644 drivers/soc/samsung/exynos-pmu.c
>> create mode 100644 drivers/soc/samsung/exynos-pmu.h
>> create mode 100644 drivers/soc/samsung/exynos3250-pmu.c
>> create mode 100644 drivers/soc/samsung/exynos4-pmu.c
>> create mode 100644 drivers/soc/samsung/exynos5250-pmu.c
>> create mode 100644 drivers/soc/samsung/exynos5420-pmu.c
>> rename {arch/arm/mach-exynos => include/linux/soc/samsung}/exynos-pmu.h (90%)
>> rename arch/arm/mach-exynos/regs-pmu.h => include/linux/soc/samsung/exynos-regs-pmu.h (98%)
>>
>
>
On 05.11.2015 14:27, Pankaj Dubey wrote:
> Hi Krzysztof,
>
> On Tuesday 03 November 2015 07:36 AM, Krzysztof Kozlowski wrote:
>> On 26.10.2015 21:55, Pankaj Dubey wrote:
>>> This patch series is a part of continuation work from following series
>>> [1] and [2].
>>>
>>> 1: exynos: Move pmu driver to driver/soc folder and add exynos7 support
>>> http://www.spinics.net/lists/linux-samsung-soc/msg39797.html from
>>> Amit Daniel Kacchap
>>> 2: soc: samsung: pmu: split up SoC specific PMU data
>>> https://lkml.org/lkml/2015/1/7/12 from me
>>>
>>
>> +Cc Bartlomiej,
>>
>> There were some concerns for previous versions of this patchset. I
>> cannot find all of them (e.g. Bartlomiej's are not present on lkml.org
>> anymore) so I am not sure if they were addressed properly.
>>
>
> Yes. If I recall correctly he has following main concerns:
> 1: To convert exynos-pmu to a proper platform driver before moving out
> of arch/arm/mach-exynos. This is already addressed.
>
> 2: Do we really need common driver for both ARM and ARM64? I feel yes,
> as at least I can see that driver's basic structure will be reused. As
> in case of PMU driver most of lines of code is data part (register
> offset and its values in different mode), that part will be kept in
> separate file e.g. exynos7-pmu.c or exynosXXXX-pmu.c.
> There has been already one attempt of submission for exynos7 PMU driver at:
>
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/305418.html
>
>
> 3: He had a concern that in case of ARM64 build most of ARM related code
> will be present in binary which will be dead code, that can be addressed
> by excluding ARM based SoC exynosXXXX-pmu.c file in Makefile.
> It has been taken care in v3 7/7 patch in drivers/soc/samsung/Makefile.
>
Sounds reasonable to me. Maybe someone will have other comments but for
me it's okay. When sending next version, please CC linux-pm mailing list
and arm-soc maintainers (Arnd, Olof, Kevin).
Best regards,
Krzysztof