2022-05-10 07:32:46

by Paul Menzel

[permalink] [raw]
Subject: Re: [PATCH v9 2/3] dt-bindings: edac: nuvoton: add NPCM memory controller

Dear Medad,


Thank you for your patch.

Am 10.05.22 um 05:10 schrieb Medad CChien:
> Document devicetree bindings for the Nuvoton BMC NPCM memory controller.
>
> Signed-off-by: Medad CChien <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../edac/nuvoton,npcm-memory-controller.yaml | 61 +++++++++++++++++++
> 1 file changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
>
> diff --git a/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
> new file mode 100644
> index 000000000000..6f37211796a3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/edac/nuvoton,npcm-memory-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NPCM Memory Controller
> +
> +maintainers:
> + - Medad CChien <[email protected]>

Just a side note, that in my experience functional like
<[email protected]> instead of personal addresses
are useful, as you can configure on your side, who to deliver messages
to. For example, if you are on sick leave or vacation, you just
configure to deliver the message to a colleague of yours (or they get
messages in the first place anyway).

Maybe you can bring that up at Nuvoton.

[…]


Kind regards,

Paul


2022-05-16 07:34:45

by Medad Young

[permalink] [raw]
Subject: Re: [PATCH v9 2/3] dt-bindings: edac: nuvoton: add NPCM memory controller

Dear Paul,

thanks for your comment.

Paul Menzel <[email protected]> 於 2022年5月10日 週二 下午2:14寫道:
>
> Dear Medad,
>
>
> Thank you for your patch.
>
> Am 10.05.22 um 05:10 schrieb Medad CChien:
> > Document devicetree bindings for the Nuvoton BMC NPCM memory controller.
> >
> > Signed-off-by: Medad CChien <[email protected]>
> > Reviewed-by: Krzysztof Kozlowski <[email protected]>
> > ---
> > .../edac/nuvoton,npcm-memory-controller.yaml | 61 +++++++++++++++++++
> > 1 file changed, 61 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
> > new file mode 100644
> > index 000000000000..6f37211796a3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/edac/nuvoton,npcm-memory-controller.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Nuvoton NPCM Memory Controller
> > +
> > +maintainers:
> > + - Medad CChien <[email protected]>
>
> Just a side note, that in my experience functional like
> <[email protected]> instead of personal addresses
> are useful, as you can configure on your side, who to deliver messages
> to. For example, if you are on sick leave or vacation, you just
> configure to deliver the message to a colleague of yours (or they get
> messages in the first place anyway).
>
> Maybe you can bring that up at Nuvoton.
>

I understand, but we do not have group email address.
so maybe I should add more maintainers?

> […]
>
>
> Kind regards,
>
> Paul

B.R.
Medad

2022-05-18 05:17:28

by Paul Menzel

[permalink] [raw]
Subject: Re: [PATCH v9 2/3] dt-bindings: edac: nuvoton: add NPCM memory controller

Dear Medad,


Am 16.05.22 um 04:30 schrieb Medad Young:

> Paul Menzel 於 2022年5月10日 週二 下午2:14寫道:

>> Am 10.05.22 um 05:10 schrieb Medad CChien:
>>> Document devicetree bindings for the Nuvoton BMC NPCM memory controller.
>>>
>>> Signed-off-by: Medad CChien <[email protected]>
>>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>>> ---
>>> .../edac/nuvoton,npcm-memory-controller.yaml | 61 +++++++++++++++++++
>>> 1 file changed, 61 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
>>> new file mode 100644
>>> index 000000000000..6f37211796a3
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
>>> @@ -0,0 +1,61 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/edac/nuvoton,npcm-memory-controller.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Nuvoton NPCM Memory Controller
>>> +
>>> +maintainers:
>>> + - Medad CChien <[email protected]>
>>
>> Just a side note, that in my experience functional like
>> <[email protected]> instead of personal addresses
>> are useful, as you can configure on your side, who to deliver messages
>> to. For example, if you are on sick leave or vacation, you just
>> configure to deliver the message to a colleague of yours (or they get
>> messages in the first place anyway).
>>
>> Maybe you can bring that up at Nuvoton.
>
> I understand, but we do not have group email address.
> so maybe I should add more maintainers?

If there are actually more maintainers, responsible and knowledgeable
for that driver, than yes, these should be added (until you get a
function address set up).


Kind regards,

Paul

2022-05-19 03:11:18

by Medad Young

[permalink] [raw]
Subject: Re: [PATCH v9 2/3] dt-bindings: edac: nuvoton: add NPCM memory controller

Dear Paul,

Paul Menzel <[email protected]> 於 2022年5月18日 週三 下午12:33寫道:
>
> Dear Medad,
>
>
> Am 16.05.22 um 04:30 schrieb Medad Young:
>
> > Paul Menzel 於 2022年5月10日 週二 下午2:14寫道:
>
> >> Am 10.05.22 um 05:10 schrieb Medad CChien:
> >>> Document devicetree bindings for the Nuvoton BMC NPCM memory controller.
> >>>
> >>> Signed-off-by: Medad CChien <[email protected]>
> >>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> >>> ---
> >>> .../edac/nuvoton,npcm-memory-controller.yaml | 61 +++++++++++++++++++
> >>> 1 file changed, 61 insertions(+)
> >>> create mode 100644 Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
> >>> new file mode 100644
> >>> index 000000000000..6f37211796a3
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
> >>> @@ -0,0 +1,61 @@
> >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> >>> +%YAML 1.2
> >>> +---
> >>> +$id: http://devicetree.org/schemas/edac/nuvoton,npcm-memory-controller.yaml#
> >>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>> +
> >>> +title: Nuvoton NPCM Memory Controller
> >>> +
> >>> +maintainers:
> >>> + - Medad CChien <[email protected]>
> >>
> >> Just a side note, that in my experience functional like
> >> <[email protected]> instead of personal addresses
> >> are useful, as you can configure on your side, who to deliver messages
> >> to. For example, if you are on sick leave or vacation, you just
> >> configure to deliver the message to a colleague of yours (or they get
> >> messages in the first place anyway).
> >>
> >> Maybe you can bring that up at Nuvoton.
> >
> > I understand, but we do not have group email address.
> > so maybe I should add more maintainers?
>
> If there are actually more maintainers, responsible and knowledgeable
> for that driver, than yes, these should be added (until you get a
> function address set up).
>

OK, thanks

>
> Kind regards,
>
> Paul

B.R.
Medad