2015-12-17 15:06:05

by Paul Gortmaker

Subject: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c

In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial:
make serial/atmel_serial.c explicitly non-modular") we removed the code
relating to modular support since it currently only supports built in.

However, when redoing my build coverage for mips allmodconfig, which
sets CONFIG_OF, I noticed a remaining line that needs to be removed,
else we will get a build failure for an undefined module macro.

Unfortunately this didn't appear for any of the other arch I tested
more frequently, such as ARM.

Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just
remove the offending line.

Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
Cc: Nicolas Ferre <[email protected]>
Cc: Jiri Slaby <[email protected]>
Cc: [email protected]
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Sudip Mukherjee <[email protected]>
Reported-by: Sudip Mukherjee <[email protected]>
Signed-off-by: Paul Gortmaker <[email protected]>
---
drivers/tty/serial/atmel_serial.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 50e785a0ea73..1c0884d8ef32 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = {
{ .compatible = "atmel,at91sam9260-usart" },
{ /* sentinel */ }
};
-
-MODULE_DEVICE_TABLE(of, atmel_serial_dt_ids);
#endif

static inline struct atmel_uart_port *
--
2.6.1

2015-12-17 15:43:23

by Nicolas Ferre

Subject: Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c

Le 17/12/2015 16:05, Paul Gortmaker a ?crit :
> In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial:
> make serial/atmel_serial.c explicitly non-modular") we removed the code
> relating to modular support since it currently only supports built in.
>
> However, when redoing my build coverage for mips allmodconfig, which
> sets CONFIG_OF, I noticed a remaining line that needs to be removed,
> else we will get a build failure for an undefined module macro.
>
> Unfortunately this didn't appear for any of the other arch I tested
> more frequently, such as ARM.
>
> Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just
> remove the offending line.
>
> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> Cc: Nicolas Ferre <[email protected]>

Absolutely:
Acked-by: Nicolas Ferre <[email protected]>

Thank you Sudip and Paul.

Bye,


> Cc: Jiri Slaby <[email protected]>
> Cc: [email protected]
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Sudip Mukherjee <[email protected]>
> Reported-by: Sudip Mukherjee <[email protected]>
> Signed-off-by: Paul Gortmaker <[email protected]>
> ---
> drivers/tty/serial/atmel_serial.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 50e785a0ea73..1c0884d8ef32 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = {
> { .compatible = "atmel,at91sam9260-usart" },
> { /* sentinel */ }
> };
> -
> -MODULE_DEVICE_TABLE(of, atmel_serial_dt_ids);
> #endif
>
> static inline struct atmel_uart_port *
>


--
Nicolas Ferre

2015-12-17 16:48:56

by Sudip Mukherjee

Subject: Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c

On Thu, Dec 17, 2015 at 10:05:46AM -0500, Paul Gortmaker wrote:
> In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial:
> make serial/atmel_serial.c explicitly non-modular") we removed the code
> relating to modular support since it currently only supports built in.
>
> However, when redoing my build coverage for mips allmodconfig, which
> sets CONFIG_OF, I noticed a remaining line that needs to be removed,
> else we will get a build failure for an undefined module macro.
>
> Unfortunately this didn't appear for any of the other arch I tested
> more frequently, such as ARM.
>
> Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just
> remove the offending line.
>
> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> Cc: Nicolas Ferre <[email protected]>
> Cc: Jiri Slaby <[email protected]>
> Cc: [email protected]
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Sudip Mukherjee <[email protected]>
> Reported-by: Sudip Mukherjee <[email protected]>

Acked-by: Sudip Mukherjee <[email protected]>

regards
sudip