2019-11-08 09:45:33

by James Tai [戴志峰]

Subject: [PATCH v2 0/2] Initial RTD1619 SoC and Realtek Mjolnir EVB support

Hi Andreas,

This series adds Device Trees for the Realtek RTD1619 SoC and Realtek's
Mjolnir EVB.

v1 -> v2:
* Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir
* Add uart1 and uart2 device node into rtd16xx.dtsi
* move cpus node and the interrupt-affinity into rtd16xx.dtsi
* Specify the r-bus ranges

James Tai (2):
dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB
arm64: dts: Initial RTD1619 SoC and Realtek Mjolnir EVB support

.../devicetree/bindings/arm/realtek.yaml | 6 +
arch/arm64/boot/dts/realtek/Makefile | 2 +
.../boot/dts/realtek/rtd1619-mjolnir.dts | 40 +++++
arch/arm64/boot/dts/realtek/rtd1619.dtsi | 12 ++
arch/arm64/boot/dts/realtek/rtd16xx.dtsi | 154 ++++++++++++++++++
5 files changed, 214 insertions(+)
create mode 100644 arch/arm64/boot/dts/realtek/rtd1619-mjolnir.dts
create mode 100644 arch/arm64/boot/dts/realtek/rtd1619.dtsi
create mode 100644 arch/arm64/boot/dts/realtek/rtd16xx.dtsi

--
2.17.1

2019-11-11 04:22:54

by Andreas Färber

Subject: Re: [PATCH v2 0/2] Initial RTD1619 SoC and Realtek Mjolnir EVB support

Hi James,

Am 08.11.19 um 10:42 schrieb James Tai:
> This series adds Device Trees for the Realtek RTD1619 SoC and Realtek's
> Mjolnir EVB.
>
> v1 -> v2:
> * Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir
> * Add uart1 and uart2 device node into rtd16xx.dtsi
> * move cpus node and the interrupt-affinity into rtd16xx.dtsi
> * Specify the r-bus ranges

With the exception of r-bus this is getting pretty good already.
Two formal improvements:

1) The patches 1/2 and 2/2 are expected to be threaded to 0/2 (but not
2/2 to 1/2). Please check your git [sendemail] config or use --thread
--no-chain-reply-to. That helps keep the series together when people
start replying to individual patches. If your Git config seems correct,
it might also be an issue with your SMTP server.

2) Please also include a per-patch changelog like I do. I privately
shared a script how I do that in a reproducible way. This benefits
reviewers not getting CC'ed on the cover letter as well as users of the
Patchwork web interface.

Thanks,
Andreas

--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

2019-11-13 02:22:46

by James Tai [戴志峰]

Subject: RE: [PATCH v2 0/2] Initial RTD1619 SoC and Realtek Mjolnir EVB support

Hi Andreas,

> 1) The patches 1/2 and 2/2 are expected to be threaded to 0/2 (but not
> 2/2 to 1/2). Please check your git [sendemail] config or use --thread
> --no-chain-reply-to. That helps keep the series together when people start
> replying to individual patches. If your Git config seems correct, it might also be
> an issue with your SMTP server.

The git config is correct. I'll check my SMTP server.

Regards,
James