2016-03-16 22:26:14

by Babu Moger

[permalink] [raw]
Subject: Re: [PATCH v2] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

Its been a while since I submit this patch. Ping 1.

On 1/8/2016 9:39 AM, Babu Moger wrote:
> I have never seen auto handoff working on TI and RENESAS cards.
> Eventually, we force handoff. This code forces the handoff
> unconditionally. It saves 5 seconds boot time for each card.
>
> Signed-off-by: Babu Moger <[email protected]>
> ---
> v2:
> Made changes per comments from Greg KH.
> Extra space removal in assignment
> Added both vendor and device id checks.
>
> drivers/usb/host/pci-quirks.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index f940056..0915f44 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -1003,6 +1003,14 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
> ext_cap_offset = xhci_find_next_cap_offset(base, ext_cap_offset);
> } while (1);
>
> + /* Auto handoff never worked for these devices. Force it and continue */
> + if ((pdev->vendor == PCI_VENDOR_ID_TI && pdev->device == 0x8241) ||
> + (pdev->vendor == PCI_VENDOR_ID_RENESAS
> + && pdev->device == 0x0014)) {
> + val = (val | XHCI_HC_OS_OWNED) & ~XHCI_HC_BIOS_OWNED;
> + writel(val, base + ext_cap_offset);
> + }
> +
> /* If the BIOS owns the HC, signal that the OS wants it, and wait */
> if (val & XHCI_HC_BIOS_OWNED) {
> writel(val | XHCI_HC_OS_OWNED, base + ext_cap_offset);
>