2022-03-18 22:59:15

by Heikki Krogerus

[permalink] [raw]
Subject: Re: ucsi_acpi: probe of USBC000:00 fails with ioremap error

Hi Paul,

On Fri, Mar 18, 2022 at 01:36:37PM +0100, Paul Menzel wrote:
> Dear Linux folks,
>
>
> On a Dell Precision 3540, Linux 5.16.12 reports an ioremap error:
>
> [ 0.000000] Linux version 5.16.0-4-amd64
> ([email protected]) (gcc-11 (Debian 11.2.0-18) 11.2.0, GNU ld
> (GNU Binutils for Debian) 2.38) #1 SMP PREEMPT Debian 5.16.12-1 (2022-03-08)
> [ 0.000000] Command line: BOOT_IMAGE=/vmlinuz-5.16.0-4-amd64
> root=UUID=c9342a55-b747-4442-b2f4-bc03eb7a51cf ro quiet noisapnp
> log_buf_len=2M cryptomgr.notests btusb.enable_autosuspend=y
> random.trust_cpu=on
> […]
> [ 0.000000] DMI: Dell Inc. Precision 3540/0M14W7, BIOS 1.15.0
> 12/08/2021
> […]
> [ 24.230968] videodev: Linux video capture interface: v2.00
> [ 24.237747] ioremap error for 0x78e31000-0x78e32000, requested 0x2,
> got 0x0
> [ 24.238100] ucsi_acpi: probe of USBC000:00 failed with error -12
> […]
> $ sudo more /proc/iomem
> […]
> 78a04000-78ea2fff : ACPI Non-volatile Storage
> 78e31000-78e31fff : USBC000:00
> […]
>
> This seems to happen on a lot of Dell devices, cf. bug 199741 (ioremap error
> on Dell XPS 9370) [1].

I'm not sure if this helps, but I'm going to change the ioremap() call
to memremap() soon in any case in this driver. Can you test the
attached patch?

thanks,

--
heikki


Attachments:
(No filename) (1.38 kB)
0001-usb-typec-ucsi-acpi-Map-the-mailbox-with-memremap.patch (2.10 kB)
Download all attachments

2022-03-21 22:47:54

by Paul Menzel

[permalink] [raw]
Subject: Re: ucsi_acpi: probe of USBC000:00 fails with ioremap error

[Cc: +Kai-Heng, +Hans]

Dear Heikki,


Am 18.03.22 um 15:37 schrieb Heikki Krogerus:

> On Fri, Mar 18, 2022 at 01:36:37PM +0100, Paul Menzel wrote:

>> On a Dell Precision 3540, Linux 5.16.12 reports an ioremap error:
>>
>> [ 0.000000] Linux version 5.16.0-4-amd64 ([email protected]) (gcc-11 (Debian 11.2.0-18) 11.2.0, GNU ld (GNU Binutils for Debian) 2.38) #1 SMP PREEMPT Debian 5.16.12-1 (2022-03-08)
>> [ 0.000000] Command line: BOOT_IMAGE=/vmlinuz-5.16.0-4-amd64 root=UUID=c9342a55-b747-4442-b2f4-bc03eb7a51cf ro quiet noisapnp log_buf_len=2M cryptomgr.notests btusb.enable_autosuspend=y random.trust_cpu=on
>> […]
>> [ 0.000000] DMI: Dell Inc. Precision 3540/0M14W7, BIOS 1.15.0 12/08/2021
>> […]
>> [ 24.230968] videodev: Linux video capture interface: v2.00
>> [ 24.237747] ioremap error for 0x78e31000-0x78e32000, requested 0x2, got 0x0
>> [ 24.238100] ucsi_acpi: probe of USBC000:00 failed with error -12
>> […]
>> $ sudo more /proc/iomem
>> […]
>> 78a04000-78ea2fff : ACPI Non-volatile Storage
>> 78e31000-78e31fff : USBC000:00
>> […]
>>
>> This seems to happen on a lot of Dell devices, cf. bug 199741 (ioremap error
>> on Dell XPS 9370) [1].
>
> I'm not sure if this helps, but I'm going to change the ioremap() call
> to memremap() soon in any case in this driver. Can you test the
> attached patch?

Thank you very much for the instant reply and patch. Unfortunately, the
device is in active use by a user, so I do not think I am going to able
able to test it. I had hoped that the Dell client Linux kernel team
could help out, or that the Intel Linux folks have access to recent Dell
devices internally. Maybe Kai-Heng or Hans have an idea.


Kind regards,

Paul


PS: If there is a way to test this with a QEMU VM by passing through
some devices, I should be able to test that, as it does not involve a
system reboot.