2017-12-02 10:21:19

by Nishanth Menon

[permalink] [raw]
Subject: [PATCH] firmware: ti_sci: Use %zu for size_t print format

mbox_msg->len is of type size_t and %d is incorrect format. Instead
use %zu for handling size_t correctly.

Signed-off-by: Nishanth Menon <[email protected]>
---
drivers/firmware/ti_sci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 23b12d99ddfe..5229036dcfbf 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -287,13 +287,13 @@ static void ti_sci_rx_callback(struct mbox_client *cl, void *m)

/* Is the message of valid length? */
if (mbox_msg->len > info->desc->max_msg_size) {
- dev_err(dev, "Unable to handle %d xfer(max %d)\n",
+ dev_err(dev, "Unable to handle %zu xfer(max %d)\n",
mbox_msg->len, info->desc->max_msg_size);
ti_sci_dump_header_dbg(dev, hdr);
return;
}
if (mbox_msg->len < xfer->rx_len) {
- dev_err(dev, "Recv xfer %d < expected %d length\n",
+ dev_err(dev, "Recv xfer %zu < expected %d length\n",
mbox_msg->len, xfer->rx_len);
ti_sci_dump_header_dbg(dev, hdr);
return;
--
2.14.1


2017-12-13 08:01:29

by Lokesh Vutla

[permalink] [raw]
Subject: Re: [PATCH] firmware: ti_sci: Use %zu for size_t print format



On Saturday 02 December 2017 03:50 PM, Nishanth Menon wrote:
> mbox_msg->len is of type size_t and %d is incorrect format. Instead
> use %zu for handling size_t correctly.
>
> Signed-off-by: Nishanth Menon <[email protected]>

Reviewed-by: Lokesh Vutla <[email protected]>

Thanks and regards,
Lokesh

2017-12-16 22:44:47

by Santosh Shilimkar

[permalink] [raw]
Subject: Re: [PATCH] firmware: ti_sci: Use %zu for size_t print format

On 12/2/17 2:20 AM, Nishanth Menon wrote:
> mbox_msg->len is of type size_t and %d is incorrect format. Instead
> use %zu for handling size_t correctly.
>
> Signed-off-by: Nishanth Menon <[email protected]>
> ---
Applied to 'for_4.16/drivers-soc' with Lokesh's ack.