2021-03-30 03:21:38

by Jisheng Zhang

Subject: [PATCH] arm: ptdump: add __init section marker to three functions

They are not needed after booting, so mark them as __init to move them
to the .init section.

Signed-off-by: Jisheng Zhang <[email protected]>
---
arch/arm/mm/dump.c | 4 ++--
arch/arm/mm/ptdump_debugfs.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mm/dump.c b/arch/arm/mm/dump.c
index 93ff0097f00b..fb688003d156 100644
--- a/arch/arm/mm/dump.c
+++ b/arch/arm/mm/dump.c
@@ -420,7 +420,7 @@ void ptdump_walk_pgd(struct seq_file *m, struct ptdump_info *info)
note_page(&st, 0, 0, 0, NULL);
}

-static void ptdump_initialize(void)
+static void __init ptdump_initialize(void)
{
unsigned i, j;

@@ -466,7 +466,7 @@ void ptdump_check_wx(void)
pr_info("Checked W+X mappings: passed, no W+X pages found\n");
}

-static int ptdump_init(void)
+static int __init ptdump_init(void)
{
ptdump_initialize();
ptdump_debugfs_register(&kernel_ptdump_info, "kernel_page_tables");
diff --git a/arch/arm/mm/ptdump_debugfs.c b/arch/arm/mm/ptdump_debugfs.c
index 598b636615a2..8df9afac8d81 100644
--- a/arch/arm/mm/ptdump_debugfs.c
+++ b/arch/arm/mm/ptdump_debugfs.c
@@ -24,7 +24,7 @@ static const struct file_operations ptdump_fops = {
.release = single_release,
};

-void ptdump_debugfs_register(struct ptdump_info *info, const char *name)
+void __init ptdump_debugfs_register(struct ptdump_info *info, const char *name)
{
debugfs_create_file(name, 0400, NULL, info, &ptdump_fops);
}
--
2.31.0

2021-04-07 21:01:17

by Steven Price

Subject: Re: [PATCH] arm: ptdump: add __init section marker to three functions

On 30/03/2021 04:19, Jisheng Zhang wrote:
> They are not needed after booting, so mark them as __init to move them
> to the .init section.
>
> Signed-off-by: Jisheng Zhang <[email protected]>

Reviewed-by: Steven Price <[email protected]>

> ---
> arch/arm/mm/dump.c | 4 ++--
> arch/arm/mm/ptdump_debugfs.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mm/dump.c b/arch/arm/mm/dump.c
> index 93ff0097f00b..fb688003d156 100644
> --- a/arch/arm/mm/dump.c
> +++ b/arch/arm/mm/dump.c
> @@ -420,7 +420,7 @@ void ptdump_walk_pgd(struct seq_file *m, struct ptdump_info *info)
> note_page(&st, 0, 0, 0, NULL);
> }
>
> -static void ptdump_initialize(void)
> +static void __init ptdump_initialize(void)
> {
> unsigned i, j;
>
> @@ -466,7 +466,7 @@ void ptdump_check_wx(void)
> pr_info("Checked W+X mappings: passed, no W+X pages found\n");
> }
>
> -static int ptdump_init(void)
> +static int __init ptdump_init(void)
> {
> ptdump_initialize();
> ptdump_debugfs_register(&kernel_ptdump_info, "kernel_page_tables");
> diff --git a/arch/arm/mm/ptdump_debugfs.c b/arch/arm/mm/ptdump_debugfs.c
> index 598b636615a2..8df9afac8d81 100644
> --- a/arch/arm/mm/ptdump_debugfs.c
> +++ b/arch/arm/mm/ptdump_debugfs.c
> @@ -24,7 +24,7 @@ static const struct file_operations ptdump_fops = {
> .release = single_release,
> };
>
> -void ptdump_debugfs_register(struct ptdump_info *info, const char *name)
> +void __init ptdump_debugfs_register(struct ptdump_info *info, const char *name)
> {
> debugfs_create_file(name, 0400, NULL, info, &ptdump_fops);
> }
>