2022-10-06 05:56:13

by Christophe Leroy

Subject: [PATCH] video: fbdev: mb862xx: Replace NO_IRQ by 0

NO_IRQ is used to check the return of irq_of_parse_and_map().

On some architecture NO_IRQ is 0, on other architectures it is -1.

irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.

So use 0 instead of using NO_IRQ.

Signed-off-by: Christophe Leroy <[email protected]>
---
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
index a7508f5be343..3f605d2d8f0c 100644
--- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
+++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
@@ -692,7 +692,7 @@ static int of_platform_mb862xx_probe(struct platform_device *ofdev)
par->dev = dev;

par->irq = irq_of_parse_and_map(np, 0);
- if (par->irq == NO_IRQ) {
+ if (!par->irq) {
dev_err(dev, "failed to map irq\n");
ret = -ENODEV;
goto fbrel;
--
2.37.1

2022-10-08 14:08:21

by Helge Deller

Subject: Re: [PATCH] video: fbdev: mb862xx: Replace NO_IRQ by 0

On 10/6/22 07:33, Christophe Leroy wrote:
> NO_IRQ is used to check the return of irq_of_parse_and_map().
>
> On some architecture NO_IRQ is 0, on other architectures it is -1.
>
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>
> So use 0 instead of using NO_IRQ.
>
> Signed-off-by: Christophe Leroy <[email protected]>

applied.
Thanks!

Helge


> ---
> drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> index a7508f5be343..3f605d2d8f0c 100644
> --- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> +++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> @@ -692,7 +692,7 @@ static int of_platform_mb862xx_probe(struct platform_device *ofdev)
> par->dev = dev;
>
> par->irq = irq_of_parse_and_map(np, 0);
> - if (par->irq == NO_IRQ) {
> + if (!par->irq) {
> dev_err(dev, "failed to map irq\n");
> ret = -ENODEV;
> goto fbrel;