2017-04-07 11:34:27

by Varsha Rao

Subject: [PATCH 4/5] drivers: char: Replace printk with pr_err.

Replace printk with pr_err to fix the checkpatch issue.

Signed-off-by: Varsha Rao <[email protected]>
---
drivers/char/misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index 1312e29..c9cd1ea 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -294,7 +294,7 @@ static int __init misc_init(void)
return 0;

fail_printk:
- printk("unable to get major %d for misc devices\n", MISC_MAJOR);
+ pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);
class_destroy(misc_class);
fail_remove:
if (ret)
--
2.9.3

2017-04-07 15:46:19

by Greg Kroah-Hartman

Subject: Re: [PATCH 4/5] drivers: char: Replace printk with pr_err.

On Fri, Apr 07, 2017 at 05:04:06PM +0530, Varsha Rao wrote:
> Replace printk with pr_err to fix the checkpatch issue.
>
> Signed-off-by: Varsha Rao <[email protected]>
> ---
> drivers/char/misc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
> index 1312e29..c9cd1ea 100644
> --- a/drivers/char/misc.c
> +++ b/drivers/char/misc.c
> @@ -294,7 +294,7 @@ static int __init misc_init(void)
> return 0;
>
> fail_printk:
> - printk("unable to get major %d for misc devices\n", MISC_MAJOR);
> + pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);

Is pr_fmt properly set to use this?

thanks,

greg k-h