2022-03-15 22:06:50

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] serial: SERIAL_SUNPLUS should depend on ARCH_SUNPLUS

Sunplus serial ports are only present on Sunplus SoCs. Hence add a
dependency on ARCH_SUNPLUS, to prevent asking the user about this driver
when configuring a kernel without Sunplus SoC support.

Fixes: 9e8d5470325f25be ("serial: sunplus-uart: Add Sunplus SoC UART Driver")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/tty/serial/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index e952ec5c7a7c00a3..5551192560bb49d3 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1566,7 +1566,7 @@ config SERIAL_LITEUART_CONSOLE

config SERIAL_SUNPLUS
tristate "Sunplus UART support"
- depends on OF || COMPILE_TEST
+ depends on ARCH_SUNPLUS || COMPILE_TEST
select SERIAL_CORE
help
Select this option if you would like to use Sunplus serial port on
--
2.25.1


2022-03-21 17:45:26

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] serial: SERIAL_SUNPLUS should depend on ARCH_SUNPLUS

On Tue, Mar 15, 2022 at 02:52:32PM +0100, Geert Uytterhoeven wrote:
> Sunplus serial ports are only present on Sunplus SoCs. Hence add a
> dependency on ARCH_SUNPLUS, to prevent asking the user about this driver
> when configuring a kernel without Sunplus SoC support.
>
> Fixes: 9e8d5470325f25be ("serial: sunplus-uart: Add Sunplus SoC UART Driver")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/tty/serial/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof