Hi Dmitry,
Sorry for troubling you. I need to push others also. Please share
your review comment.
Thanks,
On Tuesday 21 November 2017 09:41 PM, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> changes in v2 :
> Return keypad->irq insted of -ENXIO.
> changes in v3 :
> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes in v4 :
> Return -ENXIO insted of keypad->irq. Which was not correct in v3.
> changes in v5 :
> Remove changes of v3 and v4. go back to version v2. Which is correct.
> No need to check for IRQ0 and return keypad->irq insted of -ENXIO.
>
> drivers/input/keyboard/ep93xx_keypad.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
> index f77b295..01788a7 100644
> --- a/drivers/input/keyboard/ep93xx_keypad.c
> +++ b/drivers/input/keyboard/ep93xx_keypad.c
> @@ -257,8 +257,8 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
> }
>
> keypad->irq = platform_get_irq(pdev, 0);
> - if (!keypad->irq) {
> - err = -ENXIO;
> + if (keypad->irq < 0) {
> + err = keypad->irq;
> goto failed_free;
> }
>
From 1584692753430481451@xxx Tue Nov 21 16:12:58 +0000 2017
X-GM-THRID: 1584692753430481451
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread