2018-07-10 06:59:04

by piaojun

Subject: [PATCH] net/9p/client.c: add missing '\n' at the end of p9_debug()

In p9_client_getattr_dotl(), we should add '\n' at the end of printing
log.

Signed-off-by: Jun Piao <[email protected]>
---
net/9p/client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/9p/client.c b/net/9p/client.c
index 5c13431..8bc8b3e 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -1790,7 +1790,7 @@ struct p9_stat_dotl *p9_client_getattr_dotl(struct p9_fid *fid,
"<<< st_mtime_sec=%lld st_mtime_nsec=%lld\n"
"<<< st_ctime_sec=%lld st_ctime_nsec=%lld\n"
"<<< st_btime_sec=%lld st_btime_nsec=%lld\n"
- "<<< st_gen=%lld st_data_version=%lld",
+ "<<< st_gen=%lld st_data_version=%lld\n",
ret->st_result_mask, ret->qid.type, ret->qid.path,
ret->qid.version, ret->st_mode, ret->st_nlink,
from_kuid(&init_user_ns, ret->st_uid),
--

2018-07-10 07:20:54

by jiangyiwen

Subject: Re: [PATCH] net/9p/client.c: add missing '\n' at the end of p9_debug()

On 2018/7/10 14:56, piaojun wrote:
> In p9_client_getattr_dotl(), we should add '\n' at the end of printing
> log.
>
> Signed-off-by: Jun Piao <[email protected]>

Reviewed-by: Yiwen Jiang <[email protected]>

> ---
> net/9p/client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/9p/client.c b/net/9p/client.c
> index 5c13431..8bc8b3e 100644
> --- a/net/9p/client.c
> +++ b/net/9p/client.c
> @@ -1790,7 +1790,7 @@ struct p9_stat_dotl *p9_client_getattr_dotl(struct p9_fid *fid,
> "<<< st_mtime_sec=%lld st_mtime_nsec=%lld\n"
> "<<< st_ctime_sec=%lld st_ctime_nsec=%lld\n"
> "<<< st_btime_sec=%lld st_btime_nsec=%lld\n"
> - "<<< st_gen=%lld st_data_version=%lld",
> + "<<< st_gen=%lld st_data_version=%lld\n",
> ret->st_result_mask, ret->qid.type, ret->qid.path,
> ret->qid.version, ret->st_mode, ret->st_nlink,
> from_kuid(&init_user_ns, ret->st_uid),
>