2018-09-18 08:48:03

by zhong jiang

Subject: [PATCH] misc: remove redundant include moduleparam.h

module.h already contains moduleparam.h, so it is safe to remove
the redundant include.

The issue is detected with the help of Coccinelle.

eePlease enter the commit message for your changes. Lines starting

Signed-off-by: zhong jiang <[email protected]>
---
drivers/misc/mei/bus-fixup.c | 1 -
drivers/misc/vmw_vmci/vmci_host.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c
index a6f41f9..80215c3 100644
--- a/drivers/misc/mei/bus-fixup.c
+++ b/drivers/misc/mei/bus-fixup.c
@@ -17,7 +17,6 @@
#include <linux/kernel.h>
#include <linux/sched.h>
#include <linux/module.h>
-#include <linux/moduleparam.h>
#include <linux/device.h>
#include <linux/slab.h>
#include <linux/uuid.h>
diff --git a/drivers/misc/vmw_vmci/vmci_host.c b/drivers/misc/vmw_vmci/vmci_host.c
index 83e0c95..be732e5 100644
--- a/drivers/misc/vmw_vmci/vmci_host.c
+++ b/drivers/misc/vmw_vmci/vmci_host.c
@@ -15,7 +15,6 @@

#include <linux/vmw_vmci_defs.h>
#include <linux/vmw_vmci_api.h>
-#include <linux/moduleparam.h>
#include <linux/miscdevice.h>
#include <linux/interrupt.h>
#include <linux/highmem.h>
--
1.7.12.4

2018-09-18 08:50:24

by Tomas Winkler

Subject: RE: [PATCH] misc: remove redundant include moduleparam.h

> module.h already contains moduleparam.h, so it is safe to remove the
> redundant include.
>
> The issue is detected with the help of Coccinelle.
>
> eePlease enter the commit message for your changes. Lines starting
>
> Signed-off-by: zhong jiang <[email protected]>
> ---
> drivers/misc/mei/bus-fixup.c | 1 -
> drivers/misc/vmw_vmci/vmci_host.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c index
> a6f41f9..80215c3 100644
> --- a/drivers/misc/mei/bus-fixup.c
> +++ b/drivers/misc/mei/bus-fixup.c

Ack.
Tomas

> @@ -17,7 +17,6 @@
> #include <linux/kernel.h>
> #include <linux/sched.h>
> #include <linux/module.h>
> -#include <linux/moduleparam.h>
> #include <linux/device.h>
> #include <linux/slab.h>
> #include <linux/uuid.h>
> diff --git a/drivers/misc/vmw_vmci/vmci_host.c
> b/drivers/misc/vmw_vmci/vmci_host.c
> index 83e0c95..be732e5 100644
> --- a/drivers/misc/vmw_vmci/vmci_host.c
> +++ b/drivers/misc/vmw_vmci/vmci_host.c
> @@ -15,7 +15,6 @@
>
> #include <linux/vmw_vmci_defs.h>
> #include <linux/vmw_vmci_api.h>
> -#include <linux/moduleparam.h>
> #include <linux/miscdevice.h>
> #include <linux/interrupt.h>
> #include <linux/highmem.h>
> --
> 1.7.12.4

2018-09-18 08:56:23

by Greg Kroah-Hartman

Subject: Re: [PATCH] misc: remove redundant include moduleparam.h

On Tue, Sep 18, 2018 at 04:34:42PM +0800, zhong jiang wrote:
> module.h already contains moduleparam.h, so it is safe to remove
> the redundant include.
>
> The issue is detected with the help of Coccinelle.
>
> eePlease enter the commit message for your changes. Lines starting

Odd line to have in a changelog text :)

Please fix up and resend.

tanks,

greg k-h

2018-09-18 09:10:26

by zhong jiang

Subject: Re: [PATCH] misc: remove redundant include moduleparam.h

On 2018/9/18 16:55, Greg KH wrote:
> On Tue, Sep 18, 2018 at 04:34:42PM +0800, zhong jiang wrote:
>> module.h already contains moduleparam.h, so it is safe to remove
>> the redundant include.
>>
>> The issue is detected with the help of Coccinelle.
>>
>> eePlease enter the commit message for your changes. Lines starting
> Odd line to have in a changelog text :)
>
> Please fix up and resend.
It's my fault to have a odd line. I will resend. Thanks.

Sincerely,
zhong jiang
> tanks,
>
> greg k-h
>
> .
>