2018-09-20 05:12:42

by zhong jiang

Subject: [PATCH] media: qcom: remove duplicated include file

device.h have duplicated include. hence just remove
redundant include file.

Signed-off-by: zhong jiang <[email protected]>
---
drivers/media/platform/qcom/camss/camss.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
index 418996d..0823a71 100644
--- a/drivers/media/platform/qcom/camss/camss.h
+++ b/drivers/media/platform/qcom/camss/camss.h
@@ -10,7 +10,6 @@
#ifndef QC_MSM_CAMSS_H
#define QC_MSM_CAMSS_H

-#include <linux/device.h>
#include <linux/types.h>
#include <media/v4l2-async.h>
#include <media/v4l2-device.h>
--
1.7.12.4

2018-09-21 03:37:04

by zhong jiang

Subject: Re: [PATCH] media: qcom: remove duplicated include file

On 2018/9/20 13:55, Todor Tomov wrote:
> Thank you for spotting that!
>
> On 19.09.2018 21:59, zhong jiang wrote:
>> device.h have duplicated include. hence just remove
>> redundant include file.
> I think it will be better to remove the second occurrence because
> it will keep the alphabetical order of the includes.
Yep, I forget the point. Will change in v2.

Thanks,
zhong jiang
> Best regards,
> Todor Tomov
>
>> Signed-off-by: zhong jiang <[email protected]>
>> ---
>> drivers/media/platform/qcom/camss/camss.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
>> index 418996d..0823a71 100644
>> --- a/drivers/media/platform/qcom/camss/camss.h
>> +++ b/drivers/media/platform/qcom/camss/camss.h
>> @@ -10,7 +10,6 @@
>> #ifndef QC_MSM_CAMSS_H
>> #define QC_MSM_CAMSS_H
>>
>> -#include <linux/device.h>
>> #include <linux/types.h>
>> #include <media/v4l2-async.h>
>> #include <media/v4l2-device.h>
>>
>
>