2017-11-18 09:15:03

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 8/10 v2] Input: twl4030-pwrbutton: Handle return value of platform_get_irq

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <[email protected]>
---
changes in v2 :
return error insted of -ENOMEM.

drivers/input/misc/twl4030-pwrbutton.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
index b307cca..64e7d4b 100644
--- a/drivers/input/misc/twl4030-pwrbutton.c
+++ b/drivers/input/misc/twl4030-pwrbutton.c
@@ -58,6 +58,9 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev)
int irq = platform_get_irq(pdev, 0);
int err;

+ if (irq < 0)
+ return irq;
+
pwr = devm_input_allocate_device(&pdev->dev);
if (!pwr) {
dev_err(&pdev->dev, "Can't allocate power button\n");
--
2.7.4


From 1584488112198415288@xxx Sun Nov 19 10:00:17 +0000 2017
X-GM-THRID: 1584488112198415288
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread