2017-12-02 17:01:15

by Arvind Yadav

Subject: [PATCH v2] gpio: ftgpio010: Fix platform_get_irq's error checking

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <[email protected]>
---
changes in v2:
It's should be 'irq <= 0' instead of 'irq < 0'.

drivers/gpio/gpio-ftgpio010.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
index 139f73d..fbb12f6 100644
--- a/drivers/gpio/gpio-ftgpio010.c
+++ b/drivers/gpio/gpio-ftgpio010.c
@@ -176,8 +176,8 @@ static int ftgpio_gpio_probe(struct platform_device *pdev)
return PTR_ERR(g->base);

irq = platform_get_irq(pdev, 0);
- if (!irq)
- return -EINVAL;
+ if (irq <= 0)
+ return irq ? irq : -EINVAL;

ret = bgpio_init(&g->gc, dev, 4,
g->base + GPIO_DATA_IN,
--
2.7.4

2017-12-02 20:25:54

by Linus Walleij

Subject: Re: [PATCH v2] gpio: ftgpio010: Fix platform_get_irq's error checking

On Sat, Dec 2, 2017 at 6:01 PM, Arvind Yadav <[email protected]> wrote:

> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> changes in v2:
> It's should be 'irq <= 0' instead of 'irq < 0'.

Yep that's the right patch! Patch applied.

Yours,
Linus Walleij