2023-02-21 10:57:27

by Wolfram Sang

Subject: [PATCH net-next] net: phy: update obsolete comment about PHY_STARTING

Commit 899a3cbbf77a ("net: phy: remove states PHY_STARTING and
PHY_PENDING") missed to update a comment in phy_probe. Remove
superfluous "Description:" prefix while we are here.

Signed-off-by: Wolfram Sang <[email protected]>
---
drivers/net/phy/phy_device.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 8cff61dbc4b5..3a515955ffd8 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -3019,9 +3019,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_phy_node);
* phy_probe - probe and init a PHY device
* @dev: device to probe and init
*
- * Description: Take care of setting up the phy_device structure,
- * set the state to READY (the driver's init function should
- * set it to STARTING if needed).
+ * Take care of setting up the phy_device structure, set the state to READY.
*/
static int phy_probe(struct device *dev)
{
--
2.30.2

2023-02-21 11:11:34

by Heiner Kallweit

Subject: Re: [PATCH net-next] net: phy: update obsolete comment about PHY_STARTING

On 21.02.2023 11:57, Wolfram Sang wrote:
> Commit 899a3cbbf77a ("net: phy: remove states PHY_STARTING and
> PHY_PENDING") missed to update a comment in phy_probe. Remove
> superfluous "Description:" prefix while we are here.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
> drivers/net/phy/phy_device.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 8cff61dbc4b5..3a515955ffd8 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -3019,9 +3019,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_phy_node);
> * phy_probe - probe and init a PHY device
> * @dev: device to probe and init
> *
> - * Description: Take care of setting up the phy_device structure,
> - * set the state to READY (the driver's init function should
> - * set it to STARTING if needed).
> + * Take care of setting up the phy_device structure, set the state to READY.
> */
> static int phy_probe(struct device *dev)
> {

Reviewed-by: Heiner Kallweit <[email protected]>

2023-02-21 12:24:26

by Paolo Abeni

Subject: Re: [PATCH net-next] net: phy: update obsolete comment about PHY_STARTING

On Tue, 2023-02-21 at 11:57 +0100, Wolfram Sang wrote:
> Commit 899a3cbbf77a ("net: phy: remove states PHY_STARTING and
> PHY_PENDING") missed to update a comment in phy_probe. Remove
> superfluous "Description:" prefix while we are here.
>
> Signed-off-by: Wolfram Sang <[email protected]>

# Form letter - net-next is closed

The merge window for v6.3 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after Mar 6th.

RFC patches sent for review only are obviously welcome at any time.