On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote:
> From: Anton Blanchard <[email protected]>
>
> We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as
> well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently
> use the plurals.
>
> Signed-off-by: Anton Blanchard <[email protected]>
this rename made me notice that UPROBE_EVENTS still defaults to 'n'.
this is key feature that all distros enable, so having default 'n'
is kinda saying that it's not something that should be turned on
or used widely. which is obviously not the case.
imo it's time to change it to 'y'.
Thoughts?
Added more people to the CC list.
Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
> On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote:
> > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as
> > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently
> > use the plurals.
> this rename made me notice that UPROBE_EVENTS still defaults to 'n'.
> this is key feature that all distros enable, so having default 'n'
> is kinda saying that it's not something that should be turned on
> or used widely. which is obviously not the case.
> imo it's time to change it to 'y'.
> Thoughts?
Agreed, I also found it strange that it was disabled by default when I
recently did a 'make oldconfig' :-\
- Arnaldo
On 3/15/17 7:06 PM, Arnaldo Carvalho de Melo wrote:
> Added more people to the CC list.
>
> Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
>> On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote:
>>> We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as
>>> well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently
>>> use the plurals.
>
>> this rename made me notice that UPROBE_EVENTS still defaults to 'n'.
>> this is key feature that all distros enable, so having default 'n'
>> is kinda saying that it's not something that should be turned on
>> or used widely. which is obviously not the case.
>> imo it's time to change it to 'y'.
>> Thoughts?
>
> Agreed, I also found it strange that it was disabled by default when I
> recently did a 'make oldconfig' :-\
Debian stretch, Ubuntu 16.10, Fedora 26 all have it enabled. Perhaps it
should default on.
On Wed, Mar 15, 2017 at 07:10:56PM -0600, David Ahern wrote:
> On 3/15/17 7:06 PM, Arnaldo Carvalho de Melo wrote:
> > Added more people to the CC list.
> >
> > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
> >> On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote:
> >>> We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as
> >>> well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently
> >>> use the plurals.
> >
> >> this rename made me notice that UPROBE_EVENTS still defaults to 'n'.
> >> this is key feature that all distros enable, so having default 'n'
> >> is kinda saying that it's not something that should be turned on
> >> or used widely. which is obviously not the case.
> >> imo it's time to change it to 'y'.
> >> Thoughts?
> >
> > Agreed, I also found it strange that it was disabled by default when I
> > recently did a 'make oldconfig' :-\
>
> Debian stretch, Ubuntu 16.10, Fedora 26 all have it enabled. Perhaps it
> should default on.
+1
Archlinux also has it enabled.
Thanks,
Namhyung
> Added more people to the CC list.
>
> Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
> > On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote:
> > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as
> > > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently
> > > use the plurals.
>
> > this rename made me notice that UPROBE_EVENTS still defaults to 'n'.
> > this is key feature that all distros enable, so having default 'n'
> > is kinda saying that it's not something that should be turned on
> > or used widely. which is obviously not the case.
> > imo it's time to change it to 'y'.
> > Thoughts?
>
> Agreed, I also found it strange that it was disabled by default when I
> recently did a 'make oldconfig' :-\
Yes, we could make it default on.
On 2017/3/16 9:06, Arnaldo Carvalho de Melo wrote:
> Added more people to the CC list.
>
> Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
>> On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote:
>>> We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as
>>> well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently
>>> use the plurals.
>
>> this rename made me notice that UPROBE_EVENTS still defaults to 'n'.
>> this is key feature that all distros enable, so having default 'n'
>> is kinda saying that it's not something that should be turned on
>> or used widely. which is obviously not the case.
>> imo it's time to change it to 'y'.
>> Thoughts?
> Agreed, I also found it strange that it was disabled by default when I
> recently did a 'make oldconfig' :-\
>
> - Arnaldo
+1.
Some internal distros in my company now have started
discussing supporting user space probing. Turning
uprobes on for upstream kernel helps us saving a lot
of discussion.
Thank you.
* Arnaldo Carvalho de Melo <[email protected]> wrote:
> Added more people to the CC list.
>
> Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
> > On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote:
> > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as
> > > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently
> > > use the plurals.
>
> > this rename made me notice that UPROBE_EVENTS still defaults to 'n'.
> > this is key feature that all distros enable, so having default 'n'
> > is kinda saying that it's not something that should be turned on
> > or used widely. which is obviously not the case.
> > imo it's time to change it to 'y'.
> > Thoughts?
>
> Agreed, I also found it strange that it was disabled by default when I
> recently did a 'make oldconfig' :-\
Agreed, someone please send a patch (or feel free to include it in the perf
tooling tree) to switch the default around.
Thanks,
Ingo
On Wed, 15 Mar 2017 22:06:51 -0300
Arnaldo Carvalho de Melo <[email protected]> wrote:
> Added more people to the CC list.
>
> Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
> > On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote:
> > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as
> > > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently
> > > use the plurals.
>
> > this rename made me notice that UPROBE_EVENTS still defaults to 'n'.
> > this is key feature that all distros enable, so having default 'n'
> > is kinda saying that it's not something that should be turned on
> > or used widely. which is obviously not the case.
> > imo it's time to change it to 'y'.
> > Thoughts?
>
> Agreed, I also found it strange that it was disabled by default when I
> recently did a 'make oldconfig' :-\
Agreed. Now uprobes is enough stable. (and widely used)
Thanks!
--
Masami Hiramatsu <[email protected]>
Em Thu, Mar 16, 2017 at 07:40:55AM +0100, Ingo Molnar escreveu:
>
> * Arnaldo Carvalho de Melo <[email protected]> wrote:
>
> > Added more people to the CC list.
> >
> > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu:
> > > On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote:
> > > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as
> > > > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently
> > > > use the plurals.
> >
> > > this rename made me notice that UPROBE_EVENTS still defaults to 'n'.
> > > this is key feature that all distros enable, so having default 'n'
> > > is kinda saying that it's not something that should be turned on
> > > or used widely. which is obviously not the case.
> > > imo it's time to change it to 'y'.
> > > Thoughts?
> >
> > Agreed, I also found it strange that it was disabled by default when I
> > recently did a 'make oldconfig' :-\
>
> Agreed, someone please send a patch (or feel free to include it in the perf
> tooling tree) to switch the default around.
Ok, will collect the agreements as Acked-by tags and put it in
perf/core.
- Arnaldo
Commit-ID: 61f35d750683b21e9e3836e309195c79c1daed74
Gitweb: http://git.kernel.org/tip/61f35d750683b21e9e3836e309195c79c1daed74
Author: Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 16 Mar 2017 12:42:02 -0300
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 16 Mar 2017 12:42:02 -0300
uprobes: Default UPROBES_EVENTS to Y
As it is already turned on by most distros, so just flip the default to
Y.
Suggested-by: Alexei Starovoitov <[email protected]>
Acked-by: David Ahern <[email protected]>
Acked-by: Ingo Molnar <[email protected]>
Acked-by: Masami Hiramatsu <[email protected]>
Acked-by: Namhyung Kim <[email protected]>
Acked-by: Srikar Dronamraju <[email protected]>
Acked-by: Wang Nan <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Anton Blanchard <[email protected]>
Cc: David Miller <[email protected]>
Cc: Hemant Kumar <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Steven Rostedt <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
kernel/trace/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index d4a06e7..9619b57 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -455,7 +455,7 @@ config UPROBE_EVENTS
select UPROBES
select PROBE_EVENTS
select TRACING
- default n
+ default y
help
This allows the user to add tracing events on top of userspace
dynamic events (similar to tracepoints) on the fly via the trace