powerpc's asm/prom.h brings some headers that it doesn't
need itself.
In order to clean it up in a further step, first clean all
files that include asm/prom.h
Some files don't need asm/prom.h at all. For those ones,
just remove inclusion of asm/prom.h
Some files don't need any of the items provided by asm/prom.h,
but need some of the headers included by asm/prom.h. For those
ones, add the needed headers that are brought by asm/prom.h at
the moment, then remove asm/prom.h
Some files really need asm/prom.h but also need some of the
headers included by asm/prom.h. For those one, leave asm/prom.h
but also add the needed headers so that they can be removed
from asm/prom.h in a later step.
Signed-off-by: Christophe Leroy <[email protected]>
---
v2: More detailed commit description
---
drivers/net/sungem_phy.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c
index 4daac5fda073..ff22b6b1c686 100644
--- a/drivers/net/sungem_phy.c
+++ b/drivers/net/sungem_phy.c
@@ -29,11 +29,7 @@
#include <linux/mii.h>
#include <linux/ethtool.h>
#include <linux/delay.h>
-
-#ifdef CONFIG_PPC_PMAC
-#include <asm/prom.h>
-#endif
-
+#include <linux/of.h>
#include <linux/sungem_phy.h>
/* Link modes of the BCM5400 PHY */
--
2.35.1
Hello,
On Fri, 2022-04-15 at 10:43 +0200, Christophe Leroy wrote:
> powerpc's asm/prom.h brings some headers that it doesn't
> need itself.
>
> In order to clean it up in a further step, first clean all
> files that include asm/prom.h
>
> Some files don't need asm/prom.h at all. For those ones,
> just remove inclusion of asm/prom.h
>
> Some files don't need any of the items provided by asm/prom.h,
> but need some of the headers included by asm/prom.h. For those
> ones, add the needed headers that are brought by asm/prom.h at
> the moment, then remove asm/prom.h
>
> Some files really need asm/prom.h but also need some of the
> headers included by asm/prom.h. For those one, leave asm/prom.h
> but also add the needed headers so that they can be removed
> from asm/prom.h in a later step.
This commit message is a little confusing, as this patch covers only a
single case of the above. I suggest to replace re-phrase the commit
message to be more specific. You could also explcitly mention which
symbols from linux/of.h sungem_phy.c needs, if the list is short.
Thanks,
Paolo