2020-08-16 08:27:26

by Guido Günther

Subject: [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit

This was prompted by Sam's review in
https://lore.kernel.org/dri-devel/[email protected]/
and yamllint. I also added myself as maintainer, hope that's o.k.

Guido Günther (2):
dt-bindings: panel: rocktech,jh057n00900: Modernize
dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer

.../display/panel/rocktech,jh057n00900.yaml | 40 +++++++++----------
1 file changed, 19 insertions(+), 21 deletions(-)

--
2.26.2

2020-08-16 08:29:33

by Guido Günther

Subject: [PATCH 1/2] dt-bindings: panel: rocktech,jh057n00900: Modernize

- Use common properties from panel-common.yaml
- Indent comment like content
- Don't preserve newlines in description
- Indent example by four spaces

Signed-off-by: Guido Günther <[email protected]>
---
.../display/panel/rocktech,jh057n00900.yaml | 39 +++++++++----------
1 file changed, 18 insertions(+), 21 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
index d5733ef309549..c97e89707342e 100644
--- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
+++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
@@ -9,9 +9,9 @@ title: Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel
maintainers:
- Ondrej Jirman <[email protected]>

-description: |
- Rocktech JH057N00900 is a 720x1440 TFT LCD panel
- connected using a MIPI-DSI video interface.
+description:
+ Rocktech JH057N00900 is a 720x1440 TFT LCD panel
+ connected using a MIPI-DSI video interface.

allOf:
- $ref: panel-common.yaml#
@@ -19,9 +19,9 @@ allOf:
properties:
compatible:
enum:
- # Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel
+ # Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel
- rocktech,jh057n00900
- # Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
+ # Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
- xingbangda,xbd599

port: true
@@ -35,13 +35,9 @@ properties:
iovcc-supply:
description: I/O voltage supply

- reset-gpios:
- description: GPIO used for the reset pin
- maxItems: 1
+ reset-gpios: true

- backlight:
- description: Backlight used by the panel
- $ref: "/schemas/types.yaml#/definitions/phandle"
+ backlight: true

required:
- compatible
@@ -57,15 +53,16 @@ examples:
#include <dt-bindings/gpio/gpio.h>

dsi {
- #address-cells = <1>;
- #size-cells = <0>;
- panel@0 {
- compatible = "rocktech,jh057n00900";
- reg = <0>;
- vcc-supply = <&reg_2v8_p>;
- iovcc-supply = <&reg_1v8_p>;
- reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
- backlight = <&backlight>;
- };
+ #address-cells = <1>;
+ #size-cells = <0>;
+ panel@0 {
+ compatible = "rocktech,jh057n00900";
+ reg = <0>;
+ vcc-supply = <&reg_2v8_p>;
+ iovcc-supply = <&reg_1v8_p>;
+ reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
+ backlight = <&backlight>;
+ };
};
+
...
--
2.26.2

2020-08-16 15:27:31

by Sam Ravnborg

Subject: Re: [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit

Hi Guido.

On Sun, Aug 16, 2020 at 09:13:41AM +0200, Guido G?nther wrote:
> This was prompted by Sam's review in
> https://lore.kernel.org/dri-devel/[email protected]/
> and yamllint. I also added myself as maintainer, hope that's o.k.
>
> Guido G?nther (2):
> dt-bindings: panel: rocktech,jh057n00900: Modernize
> dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer

Thanks for this nice clean-up, and always good with an extra person
caring for something.
Applied to drm-misc-next

Sam

>
> .../display/panel/rocktech,jh057n00900.yaml | 40 +++++++++----------
> 1 file changed, 19 insertions(+), 21 deletions(-)
>
> --
> 2.26.2

2020-08-17 08:24:11

by Guido Günther

Subject: Re: [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit

Hi,
On Sun, Aug 16, 2020 at 05:25:34PM +0200, Sam Ravnborg wrote:
> Hi Guido.
>
> On Sun, Aug 16, 2020 at 09:13:41AM +0200, Guido G?nther wrote:
> > This was prompted by Sam's review in
> > https://lore.kernel.org/dri-devel/[email protected]/
> > and yamllint. I also added myself as maintainer, hope that's o.k.
> >
> > Guido G?nther (2):
> > dt-bindings: panel: rocktech,jh057n00900: Modernize
> > dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer
>
> Thanks for this nice clean-up, and always good with an extra person
> caring for something.
> Applied to drm-misc-next

Thanks!
-- Guido

>
> Sam
>
> >
> > .../display/panel/rocktech,jh057n00900.yaml | 40 +++++++++----------
> > 1 file changed, 19 insertions(+), 21 deletions(-)
> >
> > --
> > 2.26.2
>