> Memory allocated for storing compressed pages' poitner should be
> released after f2fs_write_compressed_pages(), otherwise it will
> cause memory leak issue.
* Would an imperative wording be more appropriate (without a typo)
for the change description?
* Will the tag “Fixes” become helpful for the commit message?
Regards,
Markus
On 2020/7/20 19:31, Markus Elfring wrote:
>> Memory allocated for storing compressed pages' poitner should be
>> released after f2fs_write_compressed_pages(), otherwise it will
>> cause memory leak issue.
>
> * Would an imperative wording be more appropriate (without a typo)
> for the change description?
>
> * Will the tag “Fixes” become helpful for the commit message?
It looks this is replied from patch-robot? since I found all comments
you replied are almost the same.
And what's funny is that the reply starts being caught by another patch-bot
from Greg...
https://lkml.org/lkml/2020/6/28/157
>
> Regards,
> Markus
> .
>
>>> Memory allocated for storing compressed pages' poitner should be
>>> released after f2fs_write_compressed_pages(), otherwise it will
>>> cause memory leak issue.
>>
>> * Would an imperative wording be more appropriate (without a typo)
>> for the change description?
>>
>> * Will the tag “Fixes” become helpful for the commit message?
>
> It looks this is replied from patch-robot? since I found all comments
> you replied are almost the same.
I dare to repeat such suggestions because several patches contain
improvable details (not only in the affected source code).
Regards,
Markus