2022-06-16 00:20:16

by Edward Wu

Subject: [PATCH] ata: libata: add qc->flags in ata_qc_complete_template tracepoint

Add flags value to check the result of ata completion

Signed-off-by: Edward Wu <[email protected]>
---
include/trace/events/libata.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
index d4e631aa976f..6025dd8ba4aa 100644
--- a/include/trace/events/libata.h
+++ b/include/trace/events/libata.h
@@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
__entry->hob_feature = qc->result_tf.hob_feature;
__entry->nsect = qc->result_tf.nsect;
__entry->hob_nsect = qc->result_tf.hob_nsect;
+ __entry->flags = qc->flags;
),

TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \
--
2.17.1

2022-06-16 00:48:58

by Damien Le Moal

Subject: Re: [PATCH] ata: libata: add qc->flags in ata_qc_complete_template tracepoint

On 2022/06/16 9:16, Edward Wu wrote:
> Add flags value to check the result of ata completion
>
> Signed-off-by: Edward Wu <[email protected]>
> ---
> include/trace/events/libata.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index d4e631aa976f..6025dd8ba4aa 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
> __entry->hob_feature = qc->result_tf.hob_feature;
> __entry->nsect = qc->result_tf.nsect;
> __entry->hob_nsect = qc->result_tf.hob_nsect;
> + __entry->flags = qc->flags;
> ),
>
> TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \

Doesn't this need a Fixes tag ?

--
Damien Le Moal
Western Digital Research

2022-06-16 01:21:09

by Edward Wu

Subject: [PATCH v2] ata: libata: add qc->flags in ata_qc_complete_template tracepoint

Add flags value to check the result of ata completion

Fixes: 255c03d15a29 ("libata: Add tracepoints")
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Edward Wu <[email protected]>
---
v2:
- Add Fixes tag

include/trace/events/libata.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
index d4e631aa976f..6025dd8ba4aa 100644
--- a/include/trace/events/libata.h
+++ b/include/trace/events/libata.h
@@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
__entry->hob_feature = qc->result_tf.hob_feature;
__entry->nsect = qc->result_tf.nsect;
__entry->hob_nsect = qc->result_tf.hob_nsect;
+ __entry->flags = qc->flags;
),

TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \
--
2.17.1

2022-06-16 03:27:08

by Damien Le Moal

Subject: Re: [PATCH v2] ata: libata: add qc->flags in ata_qc_complete_template tracepoint

On 6/16/22 09:48, Edward Wu wrote:
> Add flags value to check the result of ata completion
>
> Fixes: 255c03d15a29 ("libata: Add tracepoints")
> Link: https://lkml.kernel.org/r/[email protected]

What is this Link tag for ? I do not think it is needed.
And please add:

Cc: [email protected]

> Signed-off-by: Edward Wu <[email protected]>
> ---
> v2:
> - Add Fixes tag
>
> include/trace/events/libata.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index d4e631aa976f..6025dd8ba4aa 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
> __entry->hob_feature = qc->result_tf.hob_feature;
> __entry->nsect = qc->result_tf.nsect;
> __entry->hob_nsect = qc->result_tf.hob_nsect;
> + __entry->flags = qc->flags;
> ),
>
> TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \


--
Damien Le Moal
Western Digital Research

2022-06-17 03:19:17

by Edward Wu

Subject: [PATCH v3] ata: libata: add qc->flags in ata_qc_complete_template tracepoint

Add flags value to check the result of ata completion

Fixes: 255c03d15a29 ("libata: Add tracepoints")
Cc: [email protected]
Acked-by: Damien Le Moal <[email protected]>
Signed-off-by: Edward Wu <[email protected]>
---
Thanks for your kindly guiding.

include/trace/events/libata.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
index d4e631aa976f..6025dd8ba4aa 100644
--- a/include/trace/events/libata.h
+++ b/include/trace/events/libata.h
@@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
__entry->hob_feature = qc->result_tf.hob_feature;
__entry->nsect = qc->result_tf.nsect;
__entry->hob_nsect = qc->result_tf.hob_nsect;
+ __entry->flags = qc->flags;
),

TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \
--
2.17.1

2022-06-17 03:52:05

by Edward Wu

Subject: [PATCH v4] ata: libata: add qc->flags in ata_qc_complete_template tracepoint

Add flags value to check the result of ata completion

Fixes: 255c03d15a29 ("libata: Add tracepoints")
Cc: [email protected]
Signed-off-by: Edward Wu <[email protected]>
---
Fixed, thanks again

include/trace/events/libata.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
index d4e631aa976f..6025dd8ba4aa 100644
--- a/include/trace/events/libata.h
+++ b/include/trace/events/libata.h
@@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
__entry->hob_feature = qc->result_tf.hob_feature;
__entry->nsect = qc->result_tf.nsect;
__entry->hob_nsect = qc->result_tf.hob_nsect;
+ __entry->flags = qc->flags;
),

TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \
--
2.17.1

2022-06-17 04:03:33

by Damien Le Moal

Subject: Re: [PATCH v3] ata: libata: add qc->flags in ata_qc_complete_template tracepoint

On 6/17/22 12:00, Edward Wu wrote:
> Add flags value to check the result of ata completion
>
> Fixes: 255c03d15a29 ("libata: Add tracepoints")
> Cc: [email protected]
> Acked-by: Damien Le Moal <[email protected]>

Looks good. But please do not randomly add tags like the above ack. I
never sent that ! And since I will be applying this patch, I will add my
signed-of-by tag, not a acked-by tag.

> Signed-off-by: Edward Wu <[email protected]>
> ---
> Thanks for your kindly guiding.
>
> include/trace/events/libata.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index d4e631aa976f..6025dd8ba4aa 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
> __entry->hob_feature = qc->result_tf.hob_feature;
> __entry->nsect = qc->result_tf.nsect;
> __entry->hob_nsect = qc->result_tf.hob_nsect;
> + __entry->flags = qc->flags;
> ),
>
> TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \


--
Damien Le Moal
Western Digital Research

2022-06-17 07:56:11

by Damien Le Moal

Subject: Re: [PATCH v4] ata: libata: add qc->flags in ata_qc_complete_template tracepoint

On 6/17/22 12:32, Edward Wu wrote:
> Add flags value to check the result of ata completion
>
> Fixes: 255c03d15a29 ("libata: Add tracepoints")
> Cc: [email protected]
> Signed-off-by: Edward Wu <[email protected]>
> ---
> Fixed, thanks again
>
> include/trace/events/libata.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index d4e631aa976f..6025dd8ba4aa 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
> __entry->hob_feature = qc->result_tf.hob_feature;
> __entry->nsect = qc->result_tf.nsect;
> __entry->hob_nsect = qc->result_tf.hob_nsect;
> + __entry->flags = qc->flags;
> ),
>
> TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \

Applied to for-5.19-fixes. Thanks !

--
Damien Le Moal
Western Digital Research