2023-03-25 12:26:59

by Vinod Koul

[permalink] [raw]
Subject: [PATCH v2 06/12] scsi: ufs: dt-bindings: Add SC8180x binding

Document the UFS HC for SC8180x SoC

Signed-off-by: Vinod Koul <[email protected]>
---
Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index c5a06c048389..a3db34f35f4f 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -26,6 +26,7 @@ properties:
- qcom,msm8994-ufshc
- qcom,msm8996-ufshc
- qcom,msm8998-ufshc
+ - qcom,sc8180x-ufshc
- qcom,sc8280xp-ufshc
- qcom,sdm845-ufshc
- qcom,sm6350-ufshc
@@ -105,6 +106,7 @@ allOf:
contains:
enum:
- qcom,msm8998-ufshc
+ - qcom,sc8280x-ufshc
- qcom,sc8280xp-ufshc
- qcom,sm8250-ufshc
- qcom,sm8350-ufshc
--
2.39.2


2023-03-27 08:07:02

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 06/12] scsi: ufs: dt-bindings: Add SC8180x binding

On 25/03/2023 13:24, Vinod Koul wrote:

Subject: drop second/last, redundant "binding". The "dt-bindings" prefix
is already stating that these are bindings.

Same in all other patches.

> Document the UFS HC for SC8180x SoC

Finish sentences with full stop. Same in all other patches.

>
> Signed-off-by: Vinod Koul <[email protected]>
> ---


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-03-27 10:24:35

by Manivannan Sadhasivam

[permalink] [raw]
Subject: Re: [PATCH v2 06/12] scsi: ufs: dt-bindings: Add SC8180x binding

On Sat, Mar 25, 2023 at 05:54:38PM +0530, Vinod Koul wrote:
> Document the UFS HC for SC8180x SoC
>
> Signed-off-by: Vinod Koul <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> index c5a06c048389..a3db34f35f4f 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> @@ -26,6 +26,7 @@ properties:
> - qcom,msm8994-ufshc
> - qcom,msm8996-ufshc
> - qcom,msm8998-ufshc
> + - qcom,sc8180x-ufshc
> - qcom,sc8280xp-ufshc
> - qcom,sdm845-ufshc
> - qcom,sm6350-ufshc
> @@ -105,6 +106,7 @@ allOf:
> contains:
> enum:
> - qcom,msm8998-ufshc
> + - qcom,sc8280x-ufshc
> - qcom,sc8280xp-ufshc
> - qcom,sm8250-ufshc
> - qcom,sm8350-ufshc
> --
> 2.39.2
>

--
மணிவண்ணன் சதாசிவம்