2022-11-30 10:27:25

by Javier Martinez Canillas

[permalink] [raw]
Subject: Re: [PATCH v2 17/17] drm/vc4: tests: Add unit test suite for the PV muxing

On 11/28/22 15:53, Maxime Ripard wrote:
> The HVS to PixelValve muxing code is fairly error prone and has a bunch
> of arbitrary constraints due to the hardware setup.
>
> Let's create a test suite that makes sure that the possible combinations
> work and the invalid ones don't.
>
> Signed-off-by: Maxime Ripard <[email protected]>
> ---

Thanks for this patch. It shows how powerful KUnit can be for testing drivers.

Reviewed-by: Javier Martinez Canillas <[email protected]>

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat