2010-12-14 13:56:52

by Nicolas Ferre

[permalink] [raw]
Subject: [PATCH] AT91: usb gadget: fix freeing irq in _udc_remove()

From: Rob Emanuele <[email protected]>

Add a free_irq() call on vbus gpio when we remove udc so that the
vbus irq is properly released.

Signed-off-by: Rob Emanuele <[email protected]>
Signed-off-by: Nicolas Ferre <[email protected]>
---
drivers/usb/gadget/atmel_usba_udc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
index 717ff65..e7c65a4 100644
--- a/drivers/usb/gadget/atmel_usba_udc.c
+++ b/drivers/usb/gadget/atmel_usba_udc.c
@@ -2057,8 +2057,10 @@ static int __exit usba_udc_remove(struct platform_device *pdev)
usba_ep_cleanup_debugfs(&usba_ep[i]);
usba_cleanup_debugfs(udc);

- if (gpio_is_valid(udc->vbus_pin))
+ if (gpio_is_valid(udc->vbus_pin)) {
+ free_irq(gpio_to_irq(udc->vbus_pin), udc);
gpio_free(udc->vbus_pin);
+ }

free_irq(udc->irq, udc);
kfree(usba_ep);
--
1.7.3


2010-12-14 16:21:46

by David Brownell

[permalink] [raw]
Subject: Re: [PATCH] AT91: usb gadget: fix freeing irq in _udc_remove()

You _do_ know that $SUBJECT references
an entirely different driver than $PATCH ...

2010-12-14 16:51:33

by Nicolas Ferre

[permalink] [raw]
Subject: [PATCH v2] USB: atmel_usba_udc: fix freeing irq in usba_udc_remove()

From: Rob Emanuele <[email protected]>

Add a free_irq() call on vbus gpio when we remove udc so that the
vbus irq is properly released.

Signed-off-by: Rob Emanuele <[email protected]>
Signed-off-by: Nicolas Ferre <[email protected]>
---
David,

I modified $SUBJECT to be more explicit about which driver is modified.
Hope that makes sense now...

Bye,

drivers/usb/gadget/atmel_usba_udc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
index 717ff65..e7c65a4 100644
--- a/drivers/usb/gadget/atmel_usba_udc.c
+++ b/drivers/usb/gadget/atmel_usba_udc.c
@@ -2057,8 +2057,10 @@ static int __exit usba_udc_remove(struct platform_device *pdev)
usba_ep_cleanup_debugfs(&usba_ep[i]);
usba_cleanup_debugfs(udc);

- if (gpio_is_valid(udc->vbus_pin))
+ if (gpio_is_valid(udc->vbus_pin)) {
+ free_irq(gpio_to_irq(udc->vbus_pin), udc);
gpio_free(udc->vbus_pin);
+ }

free_irq(udc->irq, udc);
kfree(usba_ep);
--
1.7.3

Subject: Re: [PATCH v2] USB: atmel_usba_udc: fix freeing irq in usba_udc_remove()

On 19:00 Tue 14 Dec , Nicolas Ferre wrote:
> From: Rob Emanuele <[email protected]>
>
> Add a free_irq() call on vbus gpio when we remove udc so that the
> vbus irq is properly released.
>
> Signed-off-by: Rob Emanuele <[email protected]>
> Signed-off-by: Nicolas Ferre <[email protected]>
> ---
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

Best Regards,
J.