2017-11-24 17:03:24

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] power: supply: cpcap-battery: Fix platform_get_irq_byname's error checking

The platform_get_irq_byname() function returns -1 if an error occurs.
zero or positive number on success. platform_get_irq_byname() error
checking for zero is not correct.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/power/supply/cpcap-battery.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
index ee71a2b..98ba078 100644
--- a/drivers/power/supply/cpcap-battery.c
+++ b/drivers/power/supply/cpcap-battery.c
@@ -586,8 +586,8 @@ static int cpcap_battery_init_irq(struct platform_device *pdev,
int irq, error;

irq = platform_get_irq_byname(pdev, name);
- if (!irq)
- return -ENODEV;
+ if (irq < 0)
+ return irq;

error = devm_request_threaded_irq(ddata->dev, irq, NULL,
cpcap_battery_irq_thread,
--
2.7.4


From 1585403248092803093@xxx Wed Nov 29 12:25:58 +0000 2017
X-GM-THRID: 1585403248092803093
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread