2023-01-03 22:03:43

by Robert Richter

Subject: [PATCH] cxl/pci: Show opcode in debug messages when sending a command

For debugging it is very helpful to see which commands are sent. Add
it to the debug message.

Signed-off-by: Robert Richter <[email protected]>
---
drivers/cxl/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
index 33083a522fd1..316089a393d0 100644
--- a/drivers/cxl/pci.c
+++ b/drivers/cxl/pci.c
@@ -162,7 +162,7 @@ static int __cxl_pci_mbox_send_cmd(struct cxl_dev_state *cxlds,
writeq(cmd_reg, cxlds->regs.mbox + CXLDEV_MBOX_CMD_OFFSET);

/* #4 */
- dev_dbg(dev, "Sending command\n");
+ dev_dbg(dev, "Sending command: 0x%04x\n", mbox_cmd->opcode);
writel(CXLDEV_MBOX_CTRL_DOORBELL,
cxlds->regs.mbox + CXLDEV_MBOX_CTRL_OFFSET);

--
2.30.2

2023-01-03 23:36:07

by Dan Williams

Subject: RE: [PATCH] cxl/pci: Show opcode in debug messages when sending a command

Robert Richter wrote:
> For debugging it is very helpful to see which commands are sent. Add
> it to the debug message.

Looks good to me, applied for v6.3.