2022-09-10 19:05:53

by Johan Jonker

Subject: [PATCH v1] dt-bindings: spi: rockchip: add power-domains property

The Rockchip rk3399 TRM mentions that pd_sdioaudio includes
sdio, spi, i2s and spdif. Add a power-domains property to
reduce notifications with spi-rockchip.yaml.

Signed-off-by: Johan Jonker <[email protected]>
---
Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml b/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
index 52768894b..66e49947b 100644
--- a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
@@ -82,6 +82,9 @@ properties:
where the "sleep" configuration may describe the state
the pins should be in during system suspend.

+ power-domains:
+ maxItems: 1
+
required:
- compatible
- reg
--
2.20.1

2022-09-10 20:43:32

by Heiko Stuebner

Subject: Re: [PATCH v1] dt-bindings: spi: rockchip: add power-domains property

Am Samstag, 10. September 2022, 20:56:28 CEST schrieb Johan Jonker:
> The Rockchip rk3399 TRM mentions that pd_sdioaudio includes
> sdio, spi, i2s and spdif. Add a power-domains property to
> reduce notifications with spi-rockchip.yaml.
>
> Signed-off-by: Johan Jonker <[email protected]>

Acked-by: Heiko Stuebner <[email protected]>


> ---
> Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml b/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
> index 52768894b..66e49947b 100644
> --- a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
> @@ -82,6 +82,9 @@ properties:
> where the "sleep" configuration may describe the state
> the pins should be in during system suspend.
>
> + power-domains:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
>

2022-09-11 13:56:43

by Krzysztof Kozlowski

Subject: Re: [PATCH v1] dt-bindings: spi: rockchip: add power-domains property

On 10/09/2022 20:56, Johan Jonker wrote:
> The Rockchip rk3399 TRM mentions that pd_sdioaudio includes
> sdio, spi, i2s and spdif. Add a power-domains property to
> reduce notifications with spi-rockchip.yaml.

Drop the last sentence - there are no notifications. Just write bindings
to match reality (hardware).

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof