2022-06-18 07:16:43

by Wei Yongjun

Subject: [PATCH -next] irqchip/apple-aic: Make symbol 'use_fast_ipi' static

The sparse tool complains as follows:

drivers/irqchip/irq-apple-aic.c:231:1: warning:
symbol 'use_fast_ipi' was not declared. Should it be static?

This symbol is not used outside of irq-apple-aic.c, so marks it static.

Fixes: 2cf68211664a ("irqchip/apple-aic: Add Fast IPI support")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/irqchip/irq-apple-aic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index 5ac83185ff47..1c2813ad8bbe 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -228,7 +228,7 @@
#define AIC_TMR_EL02_PHYS AIC_TMR_GUEST_PHYS
#define AIC_TMR_EL02_VIRT AIC_TMR_GUEST_VIRT

-DEFINE_STATIC_KEY_TRUE(use_fast_ipi);
+static DEFINE_STATIC_KEY_TRUE(use_fast_ipi);

struct aic_info {
int version;

2022-06-21 10:36:45

by Hector Martin

Subject: Re: [PATCH -next] irqchip/apple-aic: Make symbol 'use_fast_ipi' static

On 18/06/2022 16.28, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/irqchip/irq-apple-aic.c:231:1: warning:
> symbol 'use_fast_ipi' was not declared. Should it be static?
>
> This symbol is not used outside of irq-apple-aic.c, so marks it static.
>
> Fixes: 2cf68211664a ("irqchip/apple-aic: Add Fast IPI support")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/irqchip/irq-apple-aic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 5ac83185ff47..1c2813ad8bbe 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -228,7 +228,7 @@
> #define AIC_TMR_EL02_PHYS AIC_TMR_GUEST_PHYS
> #define AIC_TMR_EL02_VIRT AIC_TMR_GUEST_VIRT
>
> -DEFINE_STATIC_KEY_TRUE(use_fast_ipi);
> +static DEFINE_STATIC_KEY_TRUE(use_fast_ipi);
>
> struct aic_info {
> int version;
>
>

Reviewed-by: Hector Martin <[email protected]>

--
Hector Martin ([email protected])
Public Key: https://mrcn.st/pub

2022-07-01 14:10:38

by tip-bot2 for Haifeng Xu

Subject: [irqchip: irq/irqchip-fixes] irqchip/apple-aic: Make symbol 'use_fast_ipi' static

The following commit has been merged into the irq/irqchip-fixes branch of irqchip:

Commit-ID: 1357d2a65601bc0afb221672d5a8f1649063a141
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/1357d2a65601bc0afb221672d5a8f1649063a141
Author: Wei Yongjun <[email protected]>
AuthorDate: Sat, 18 Jun 2022 07:28:24
Committer: Marc Zyngier <[email protected]>
CommitterDate: Fri, 01 Jul 2022 14:26:13 +01:00

irqchip/apple-aic: Make symbol 'use_fast_ipi' static

The sparse tool complains as follows:

drivers/irqchip/irq-apple-aic.c:231:1: warning:
symbol 'use_fast_ipi' was not declared. Should it be static?

This symbol is not used outside of irq-apple-aic.c, so marks it static.

Fixes: 2cf68211664a ("irqchip/apple-aic: Add Fast IPI support")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
Reviewed-by: Hector Martin <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/irqchip/irq-apple-aic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index 5ac8318..1c2813a 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -228,7 +228,7 @@
#define AIC_TMR_EL02_PHYS AIC_TMR_GUEST_PHYS
#define AIC_TMR_EL02_VIRT AIC_TMR_GUEST_VIRT

-DEFINE_STATIC_KEY_TRUE(use_fast_ipi);
+static DEFINE_STATIC_KEY_TRUE(use_fast_ipi);

struct aic_info {
int version;