2020-02-06 09:04:26

by Christophe Leroy

Subject: [PATCH] selftest/lkdtm: Don't pollute 'git status'

Commit 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
added generation of lkdtm test scripts.

Ignore those generated scripts when performing 'git status'

Fixes: 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
Signed-off-by: Christophe Leroy <[email protected]>
---
.gitignore | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/.gitignore b/.gitignore
index b849a72d69d5..bb05dce58f8e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -100,6 +100,10 @@ modules.order
/include/ksym/
/arch/*/include/generated/

+# Generated lkdtm tests
+/tools/testing/selftests/lkdtm/*.sh
+!/tools/testing/selftests/lkdtm/run.sh
+
# stgit generated dirs
patches-*

--
2.25.0

2020-02-20 14:58:38

by Christophe Leroy

Subject: Re: [PATCH] selftest/lkdtm: Don't pollute 'git status'

ping

On 02/06/2020 08:11 AM, Christophe Leroy wrote:
> Commit 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
> added generation of lkdtm test scripts.
>
> Ignore those generated scripts when performing 'git status'
>
> Fixes: 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
> Signed-off-by: Christophe Leroy <[email protected]>

Without this, 'git status' now reports the following crap and real
problems are drowned in the middle, that's annoying.

On branch saf3000-5.6
Untracked files:
(use "git add <file>..." to include in what will be committed)
tools/testing/selftests/lkdtm/ACCESS_NULL.sh
tools/testing/selftests/lkdtm/ACCESS_USERSPACE.sh
tools/testing/selftests/lkdtm/ATOMIC_TIMING.sh
tools/testing/selftests/lkdtm/BUG.sh
tools/testing/selftests/lkdtm/CFI_FORWARD_PROTO.sh
tools/testing/selftests/lkdtm/CORRUPT_LIST_ADD.sh
tools/testing/selftests/lkdtm/CORRUPT_LIST_DEL.sh
tools/testing/selftests/lkdtm/CORRUPT_STACK.sh
tools/testing/selftests/lkdtm/CORRUPT_STACK_STRONG.sh
tools/testing/selftests/lkdtm/CORRUPT_USER_DS.sh
tools/testing/selftests/lkdtm/DOUBLE_FAULT.sh
tools/testing/selftests/lkdtm/EXCEPTION.sh
tools/testing/selftests/lkdtm/EXEC_DATA.sh
tools/testing/selftests/lkdtm/EXEC_KMALLOC.sh
tools/testing/selftests/lkdtm/EXEC_NULL.sh
tools/testing/selftests/lkdtm/EXEC_RODATA.sh
tools/testing/selftests/lkdtm/EXEC_STACK.sh
tools/testing/selftests/lkdtm/EXEC_USERSPACE.sh
tools/testing/selftests/lkdtm/EXEC_VMALLOC.sh
tools/testing/selftests/lkdtm/EXHAUST_STACK.sh
tools/testing/selftests/lkdtm/HARDLOCKUP.sh
tools/testing/selftests/lkdtm/HUNG_TASK.sh
tools/testing/selftests/lkdtm/LOOP.sh
tools/testing/selftests/lkdtm/OVERWRITE_ALLOCATION.sh
tools/testing/selftests/lkdtm/PANIC.sh
tools/testing/selftests/lkdtm/READ_AFTER_FREE.sh
tools/testing/selftests/lkdtm/READ_BUDDY_AFTER_FREE.sh
tools/testing/selftests/lkdtm/REFCOUNT_ADD_NOT_ZERO_OVERFLOW.sh
tools/testing/selftests/lkdtm/REFCOUNT_ADD_NOT_ZERO_SATURATED.sh
tools/testing/selftests/lkdtm/REFCOUNT_ADD_OVERFLOW.sh
tools/testing/selftests/lkdtm/REFCOUNT_ADD_SATURATED.sh
tools/testing/selftests/lkdtm/REFCOUNT_ADD_ZERO.sh
tools/testing/selftests/lkdtm/REFCOUNT_DEC_AND_TEST_NEGATIVE.sh
tools/testing/selftests/lkdtm/REFCOUNT_DEC_AND_TEST_SATURATED.sh
tools/testing/selftests/lkdtm/REFCOUNT_DEC_NEGATIVE.sh
tools/testing/selftests/lkdtm/REFCOUNT_DEC_SATURATED.sh
tools/testing/selftests/lkdtm/REFCOUNT_DEC_ZERO.sh
tools/testing/selftests/lkdtm/REFCOUNT_INC_NOT_ZERO_OVERFLOW.sh
tools/testing/selftests/lkdtm/REFCOUNT_INC_NOT_ZERO_SATURATED.sh
tools/testing/selftests/lkdtm/REFCOUNT_INC_OVERFLOW.sh
tools/testing/selftests/lkdtm/REFCOUNT_INC_SATURATED.sh
tools/testing/selftests/lkdtm/REFCOUNT_INC_ZERO.sh
tools/testing/selftests/lkdtm/REFCOUNT_SUB_AND_TEST_NEGATIVE.sh
tools/testing/selftests/lkdtm/REFCOUNT_SUB_AND_TEST_SATURATED.sh
tools/testing/selftests/lkdtm/REFCOUNT_TIMING.sh
tools/testing/selftests/lkdtm/SLAB_FREE_CROSS.sh
tools/testing/selftests/lkdtm/SLAB_FREE_DOUBLE.sh
tools/testing/selftests/lkdtm/SLAB_FREE_PAGE.sh
tools/testing/selftests/lkdtm/SOFTLOCKUP.sh
tools/testing/selftests/lkdtm/SPINLOCKUP.sh
tools/testing/selftests/lkdtm/STACKLEAK_ERASING.sh
tools/testing/selftests/lkdtm/STACK_GUARD_PAGE_LEADING.sh
tools/testing/selftests/lkdtm/STACK_GUARD_PAGE_TRAILING.sh
tools/testing/selftests/lkdtm/UNALIGNED_LOAD_STORE_WRITE.sh
tools/testing/selftests/lkdtm/UNSET_SMEP.sh
tools/testing/selftests/lkdtm/USERCOPY_HEAP_SIZE_FROM.sh
tools/testing/selftests/lkdtm/USERCOPY_HEAP_SIZE_TO.sh
tools/testing/selftests/lkdtm/USERCOPY_HEAP_WHITELIST_FROM.sh
tools/testing/selftests/lkdtm/USERCOPY_HEAP_WHITELIST_TO.sh
tools/testing/selftests/lkdtm/USERCOPY_KERNEL.sh
tools/testing/selftests/lkdtm/USERCOPY_KERNEL_DS.sh
tools/testing/selftests/lkdtm/USERCOPY_STACK_BEYOND.sh
tools/testing/selftests/lkdtm/USERCOPY_STACK_FRAME_FROM.sh
tools/testing/selftests/lkdtm/USERCOPY_STACK_FRAME_TO.sh
tools/testing/selftests/lkdtm/WARNING.sh
tools/testing/selftests/lkdtm/WARNING_MESSAGE.sh
tools/testing/selftests/lkdtm/WRITE_AFTER_FREE.sh
tools/testing/selftests/lkdtm/WRITE_BUDDY_AFTER_FREE.sh
tools/testing/selftests/lkdtm/WRITE_KERN.sh
tools/testing/selftests/lkdtm/WRITE_RO.sh
tools/testing/selftests/lkdtm/WRITE_RO_AFTER_INIT.sh

nothing added to commit but untracked files present (use "git add" to track)


Thanks
Christophe


> ---
> .gitignore | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index b849a72d69d5..bb05dce58f8e 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -100,6 +100,10 @@ modules.order
> /include/ksym/
> /arch/*/include/generated/
>
> +# Generated lkdtm tests
> +/tools/testing/selftests/lkdtm/*.sh
> +!/tools/testing/selftests/lkdtm/run.sh
> +
> # stgit generated dirs
> patches-*
>
>

2020-02-20 15:50:01

by Shuah Khan

Subject: Re: [PATCH] selftest/lkdtm: Don't pollute 'git status'

On 2/20/20 7:58 AM, Christophe Leroy wrote:
> ping
>
> On 02/06/2020 08:11 AM, Christophe Leroy wrote:
>> Commit 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
>> added generation of lkdtm test scripts.
>>
>> Ignore those generated scripts when performing 'git status'
>>
>> Fixes: 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
>> Signed-off-by: Christophe Leroy <[email protected]>
>
> Without this, 'git status' now reports the following crap and real
> problems are drowned in the middle, that's annoying.
>

I will pull this in. Please cc linux-kselftest mailing list in the
future.

thanks,
-- Shuah

2020-02-20 23:20:01

by Kees Cook

Subject: Re: [PATCH] selftest/lkdtm: Don't pollute 'git status'

On Thu, Feb 06, 2020 at 08:11:39AM +0000, Christophe Leroy wrote:
> Commit 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
> added generation of lkdtm test scripts.
>
> Ignore those generated scripts when performing 'git status'
>
> Fixes: 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
> Signed-off-by: Christophe Leroy <[email protected]>

Ah! Yes, a very good idea. Thanks!

Reviewed-by: Kees Cook <[email protected]>

-Kees

> ---
> .gitignore | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index b849a72d69d5..bb05dce58f8e 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -100,6 +100,10 @@ modules.order
> /include/ksym/
> /arch/*/include/generated/
>
> +# Generated lkdtm tests
> +/tools/testing/selftests/lkdtm/*.sh
> +!/tools/testing/selftests/lkdtm/run.sh
> +
> # stgit generated dirs
> patches-*
>
> --
> 2.25.0
>

--
Kees Cook