2021-02-23 20:05:13

by Dietmar Eggemann

Subject: Re: [PATCH] sched/fair: Fix task utilization accountability in cpu_util_next()

On 22/02/2021 10:54, [email protected] wrote:
> From: Vincent Donnefort <[email protected]>

[...]

> Also, replace sub_positive with lsub_positive which saves one explicit
> load-store.

IMHO, in case you're going to fix this now in compute_energy(), this
optimization could still be done. Maybe in an extra patch?
cpu_util_without() is using lsub_positive() to remove task util from cpu
util as well.

[...]