2023-03-07 07:59:21

by Tiezhu Yang

[permalink] [raw]
Subject: [PATCH v3 RESEND] checksyscalls: Ignore fstat to silence build warning on LoongArch

fstat is replaced by statx on the new architecture, so an exception
is added to the checksyscalls script to silence the following build
warning on LoongArch:

CALL scripts/checksyscalls.sh
<stdin>:569:2: warning: #warning syscall fstat not implemented [-Wcpp]

Suggested-by: WANG Xuerui <[email protected]>
Suggested-by: Arnd Bergmann <[email protected]>
Signed-off-by: Tiezhu Yang <[email protected]>
---

This warning still exists when build 6.3-rc1, it looks like
not so good, just resend the patch (2022-08-30):

https://lore.kernel.org/lkml/[email protected]/

scripts/checksyscalls.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
index f33e61a..1e5d2ee 100755
--- a/scripts/checksyscalls.sh
+++ b/scripts/checksyscalls.sh
@@ -114,7 +114,6 @@ cat << EOF
#define __IGNORE_truncate
#define __IGNORE_stat
#define __IGNORE_lstat
-#define __IGNORE_fstat
#define __IGNORE_fcntl
#define __IGNORE_fadvise64
#define __IGNORE_newfstatat
@@ -255,6 +254,9 @@ cat << EOF
/* 64-bit ports never needed these, and new 32-bit ports can use statx */
#define __IGNORE_fstat64
#define __IGNORE_fstatat64
+
+/* Newer ports are not required to provide fstat in favor of statx */
+#define __IGNORE_fstat
EOF
}

--
2.1.0



2023-03-07 08:15:46

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH v3 RESEND] checksyscalls: Ignore fstat to silence build warning on LoongArch

On Tue, Mar 7, 2023, at 08:59, Tiezhu Yang wrote:
> fstat is replaced by statx on the new architecture, so an exception
> is added to the checksyscalls script to silence the following build
> warning on LoongArch:
>
> CALL scripts/checksyscalls.sh
> <stdin>:569:2: warning: #warning syscall fstat not implemented [-Wcpp]
>
> Suggested-by: WANG Xuerui <[email protected]>
> Suggested-by: Arnd Bergmann <[email protected]>
> Signed-off-by: Tiezhu Yang <[email protected]>

Reviewed-by: Arnd Bergmann <[email protected]>