2018-01-12 15:51:37

by Arnd Bergmann

Subject: [PATCH] hwmon: pmbus: ibm-cffps depends on LEDS_CLASS

Building without CONFIG_LEDS_CLASS causes a link failure:

drivers/hwmon/pmbus/ibm-cffps.o: In function `ibm_cffps_probe':
ibm-cffps.c:(.text+0x4f4): undefined reference to `devm_of_led_classdev_register'

This adds the required dependency.

Fixes: f69316d62c70 ("hwmon: (pmbus) Add IBM Common Form Factor (CFF) power supply driver")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/hwmon/pmbus/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
index 08479006c7f9..6e4298e99222 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -39,6 +39,7 @@ config SENSORS_ADM1275

config SENSORS_IBM_CFFPS
tristate "IBM Common Form Factor Power Supply"
+ depends on LEDS_CLASS
help
If you say yes here you get hardware monitoring support for the IBM
Common Form Factor power supply.
--
2.9.0

2018-01-12 17:19:16

by Guenter Roeck

Subject: Re: [PATCH] hwmon: pmbus: ibm-cffps depends on LEDS_CLASS

On Fri, Jan 12, 2018 at 04:49:00PM +0100, Arnd Bergmann wrote:
> Building without CONFIG_LEDS_CLASS causes a link failure:
>
> drivers/hwmon/pmbus/ibm-cffps.o: In function `ibm_cffps_probe':
> ibm-cffps.c:(.text+0x4f4): undefined reference to `devm_of_led_classdev_register'
>
> This adds the required dependency.
>
> Fixes: f69316d62c70 ("hwmon: (pmbus) Add IBM Common Form Factor (CFF) power supply driver")
> Signed-off-by: Arnd Bergmann <[email protected]>

I wanted to let Edward decide if he wants the new dependency or conditional code
in the driver. Not having heard from him, I'll take your patch instead for now.

Thanks,
Guenter

> ---
> drivers/hwmon/pmbus/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> index 08479006c7f9..6e4298e99222 100644
> --- a/drivers/hwmon/pmbus/Kconfig
> +++ b/drivers/hwmon/pmbus/Kconfig
> @@ -39,6 +39,7 @@ config SENSORS_ADM1275
>
> config SENSORS_IBM_CFFPS
> tristate "IBM Common Form Factor Power Supply"
> + depends on LEDS_CLASS
> help
> If you say yes here you get hardware monitoring support for the IBM
> Common Form Factor power supply.
> --
> 2.9.0
>

2018-01-15 15:25:37

by Eddie James

Subject: Re: [PATCH] hwmon: pmbus: ibm-cffps depends on LEDS_CLASS

On Fri, Jan 12, 2018 at 06:19:00PM +0100, Guenter Roeck wrote:
> On Fri, Jan 12, 2018 at 04:49:00PM +0100, Arnd Bergmann wrote:
> > Building without CONFIG_LEDS_CLASS causes a link failure:
> >
> > drivers/hwmon/pmbus/ibm-cffps.o: In function `ibm_cffps_probe':
> > ibm-cffps.c:(.text+0x4f4): undefined reference to
> `devm_of_led_classdev_register'
> >
> > This adds the required dependency.
> >
> > Fixes: f69316d62c70 ("hwmon: (pmbus) Add IBM Common Form Factor
> (CFF) power supply driver")
> > Signed-off-by: Arnd Bergmann <[email protected]>
>
> I wanted to let Edward decide if he wants the new dependency or
> conditional code
> in the driver. Not having heard from him, I'll take your patch instead
> for now.

Thanks, yes this is a good solution for this driver. Didn't think about
that during testing... Thanks Arnd.

Eddie

>
> Thanks,
> Guenter
>
> > ---
> >  drivers/hwmon/pmbus/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> > index 08479006c7f9..6e4298e99222 100644
> > --- a/drivers/hwmon/pmbus/Kconfig
> > +++ b/drivers/hwmon/pmbus/Kconfig
> > @@ -39,6 +39,7 @@ config SENSORS_ADM1275
> >
> >  config SENSORS_IBM_CFFPS
> >   tristate "IBM Common Form Factor Power Supply"
> > + depends on LEDS_CLASS
> >   help
> >    If you say yes here you get hardware monitoring support for the IBM
> >    Common Form Factor power supply.
> > --
> > 2.9.0
> >
>