2021-05-01 14:18:16

by Christophe JAILLET

[permalink] [raw]
Subject: [PATCH] drm/panel: xinpeng: Fix an error handling path

'ret' is know to be >=0 a this point. Checking the return value of
'mipi_dsi_dcs_enter_sleep_mode()' was intended instead.

So add the missing assignment.

Fixes: d1479d028af2 ("drm/panel: add panel driver for Xinpeng XPP055C272 panels")
Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c
index 55172d63a922..4e51303153af 100644
--- a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c
+++ b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c
@@ -151,7 +151,7 @@ static int xpp055c272_unprepare(struct drm_panel *panel)
if (ret < 0)
dev_err(ctx->dev, "failed to set display off: %d\n", ret);

- mipi_dsi_dcs_enter_sleep_mode(dsi);
+ ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
if (ret < 0) {
dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret);
return ret;
--
2.30.2