2018-02-26 20:43:06

by Arnd Bergmann

Subject: [PATCH] ARM: omap2: set CONFIG_LIRC=y in defconfig

The CONFIG_LIRC symbol has changed from 'tristate' to 'bool, so we now
get a warning for omap2plus_defconfig:

arch/arm/configs/omap2plus_defconfig:322:warning: symbol value 'm' invalid for LIRC

This changes the file to mark the symbol as built-in to get rid of the
warning.

Fixes: a60d64b15c20 ("media: lirc: lirc interface should not be a raw decoder")
Signed-off-by: Arnd Bergmann <[email protected]>
---
arch/arm/configs/omap2plus_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index 2f145c4af93a..92674f247a12 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -319,7 +319,7 @@ CONFIG_MEDIA_CAMERA_SUPPORT=y
CONFIG_RC_CORE=m
CONFIG_MEDIA_CONTROLLER=y
CONFIG_VIDEO_V4L2_SUBDEV_API=y
-CONFIG_LIRC=m
+CONFIG_LIRC=y
CONFIG_RC_DEVICES=y
CONFIG_IR_RX51=m
CONFIG_V4L_PLATFORM_DRIVERS=y
--
2.9.0

2018-02-26 21:26:43

by Tony Lindgren

Subject: Re: [PATCH] ARM: omap2: set CONFIG_LIRC=y in defconfig

* Arnd Bergmann <[email protected]> [180226 20:42]:
> The CONFIG_LIRC symbol has changed from 'tristate' to 'bool, so we now
> get a warning for omap2plus_defconfig:
>
> arch/arm/configs/omap2plus_defconfig:322:warning: symbol value 'm' invalid for LIRC
>
> This changes the file to mark the symbol as built-in to get rid of the
> warning.
>
> Fixes: a60d64b15c20 ("media: lirc: lirc interface should not be a raw decoder")
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Tony Lindgren <[email protected]>

2018-02-27 05:56:05

by Lokesh Vutla

Subject: Re: [PATCH] ARM: omap2: set CONFIG_LIRC=y in defconfig

On Tuesday 27 February 2018 02:10 AM, Arnd Bergmann wrote:
> The CONFIG_LIRC symbol has changed from 'tristate' to 'bool, so we now
> get a warning for omap2plus_defconfig:
>
> arch/arm/configs/omap2plus_defconfig:322:warning: symbol value 'm' invalid for LIRC
>
> This changes the file to mark the symbol as built-in to get rid of the
> warning.
>
> Fixes: a60d64b15c20 ("media: lirc: lirc interface should not be a raw decoder")
> Signed-off-by: Arnd Bergmann <[email protected]>

Reviewed-by: Lokesh Vutla <[email protected]>

Thank and regards,
Lokesh

> ---
> arch/arm/configs/omap2plus_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index 2f145c4af93a..92674f247a12 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -319,7 +319,7 @@ CONFIG_MEDIA_CAMERA_SUPPORT=y
> CONFIG_RC_CORE=m
> CONFIG_MEDIA_CONTROLLER=y
> CONFIG_VIDEO_V4L2_SUBDEV_API=y
> -CONFIG_LIRC=m
> +CONFIG_LIRC=y
> CONFIG_RC_DEVICES=y
> CONFIG_IR_RX51=m
> CONFIG_V4L_PLATFORM_DRIVERS=y
>