2017-03-03 21:21:45

by Harald Geyer

[permalink] [raw]
Subject: [bug] regulator: fixed, gpio: probe fails on unset regulator-name

Hi!

Documentation/devicetree/bindings/regulator/regulator.txt says that the
regulator-name property is optional. However fixed and gpio regulators
fail in probe with the following message, if the property is not
present:

| reg-fixed-voltage regulators:sensor_supply: Failed to allocate supply
name
| reg-fixed-voltage: probe of regulators:sensor_supply failed with
error -12

This is caused by the following code in both drivers:
drvdata->desc.name = devm_kstrdup(&pdev->dev,
config->supply_name,
GFP_KERNEL);
if (drvdata->desc.name == NULL) {
dev_err(&pdev->dev, "Failed to allocate supply
name\n");
return -ENOMEM;
}

If config->supply_name == NULL, then devm_kstrdup() also returns NULL.

I don't know whether the binding document or the implementation is
wrong,
so can't propose a fix for this. Sorry.

TIA,
Harald

--
If you want to support my work:
see http://friends.ccbib.org/harald/supporting/
or donate via peercoin to P98LRdhit3gZbHDBe7ta5jtXrMJUms4p7w
or CLAM xASPBtezLNqj4cUe8MT5nZjthRSEjrRQXN


2017-03-06 10:16:56

by Mark Brown

[permalink] [raw]
Subject: Re: [bug] regulator: fixed, gpio: probe fails on unset regulator-name

On Fri, Mar 03, 2017 at 10:20:44PM +0100, Harald Geyer wrote:

> I don't know whether the binding document or the implementation is wrong,
> so can't propose a fix for this. Sorry.

The documentation for the fixed and GPIO regulators needs to be updated,
it the property is optional for general regulators but required for
them.


Attachments:
(No filename) (329.00 B)
signature.asc (488.00 B)
Download all attachments