2022-11-11 01:33:47

by Fenghua Yu

Subject: [PATCH] dmaengine: idxd: Fix crc_val field for completion record

The crc_val in the completion record should be 64 bits and not 32 bits.

Fixes: 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record")

Reported-by: Nirav N Shah <[email protected]>
Signed-off-by: Fenghua Yu <[email protected]>
---
include/uapi/linux/idxd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h
index 61ee43823622..09947ae61663 100644
--- a/include/uapi/linux/idxd.h
+++ b/include/uapi/linux/idxd.h
@@ -329,7 +329,7 @@ struct dsa_completion_record {
};

uint32_t delta_rec_size;
- uint32_t crc_val;
+ uint64_t crc_val;

/* DIF check & strip */
struct {
--
2.32.0

2022-11-11 16:11:33

by Dave Jiang

Subject: Re: [PATCH] dmaengine: idxd: Fix crc_val field for completion record

On 11/10/2022 5:27 PM, Fenghua Yu wrote:
> The crc_val in the completion record should be 64 bits and not 32 bits.
>
> Fixes: 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record")
>
> Reported-by: Nirav N Shah <[email protected]>
> Signed-off-by: Fenghua Yu <[email protected]>
Reviewed-by: Dave Jiang <[email protected]>

> ---
> include/uapi/linux/idxd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h
> index 61ee43823622..09947ae61663 100644
> --- a/include/uapi/linux/idxd.h
> +++ b/include/uapi/linux/idxd.h
> @@ -329,7 +329,7 @@ struct dsa_completion_record {
> };
>
> uint32_t delta_rec_size;
> - uint32_t crc_val;
> + uint64_t crc_val;
>
> /* DIF check & strip */
> struct {

2022-11-13 22:47:10

by Vinod Koul

Subject: Re: [PATCH] dmaengine: idxd: Fix crc_val field for completion record

On 10-11-22, 17:27, Fenghua Yu wrote:
> The crc_val in the completion record should be 64 bits and not 32 bits.
>
> Fixes: 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record")
>

Please no empty line after the fixes tag!

Applied after removing the empty line, thanks

> Reported-by: Nirav N Shah <[email protected]>
> Signed-off-by: Fenghua Yu <[email protected]>
> ---
> include/uapi/linux/idxd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h
> index 61ee43823622..09947ae61663 100644
> --- a/include/uapi/linux/idxd.h
> +++ b/include/uapi/linux/idxd.h
> @@ -329,7 +329,7 @@ struct dsa_completion_record {
> };
>
> uint32_t delta_rec_size;
> - uint32_t crc_val;
> + uint64_t crc_val;
>
> /* DIF check & strip */
> struct {
> --
> 2.32.0

--
~Vinod