2021-05-01 11:45:53

by Christophe JAILLET

Subject: [PATCH] clk: zynqmp: pll: Remove some dead code

'clk_hw_set_rate_range()' does not return any error code and 'ret' is
known to be 0 at this point, so this message can never be displayed.

Remove it.

Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver")
Signed-off-by: Christophe JAILLET <[email protected]>
---
HOWEVER, the message is about 'clk_set_rate_range()', not
'clk_hw_set_rate_range()'. So the message is maybe correct and the
'xxx_rate_range()' function incorrect.
---
drivers/clk/zynqmp/pll.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/clk/zynqmp/pll.c b/drivers/clk/zynqmp/pll.c
index abe6afbf3407..af11e9400058 100644
--- a/drivers/clk/zynqmp/pll.c
+++ b/drivers/clk/zynqmp/pll.c
@@ -331,8 +331,6 @@ struct clk_hw *zynqmp_clk_register_pll(const char *name, u32 clk_id,
}

clk_hw_set_rate_range(hw, PS_PLL_VCO_MIN, PS_PLL_VCO_MAX);
- if (ret < 0)
- pr_err("%s:ERROR clk_set_rate_range failed %d\n", name, ret);

return hw;
}
--
2.30.2

2021-05-03 04:58:36

by Rajan Vaja

Subject: RE: [PATCH] clk: zynqmp: pll: Remove some dead code

Hi,

Thanks for the patch.

> -----Original Message-----
> From: Christophe JAILLET <[email protected]>
> Sent: 01 May 2021 04:55 PM
> To: [email protected]; [email protected]; Michal Simek
> <[email protected]>; [email protected]; Rajan Vaja
> <[email protected]>; Jolly Shah <[email protected]>; Tejas Patel
> <[email protected]>; Shubhrajyoti Datta <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected]; Christophe JAILLET
> <[email protected]>
> Subject: [PATCH] clk: zynqmp: pll: Remove some dead code
>
> 'clk_hw_set_rate_range()' does not return any error code and 'ret' is
> known to be 0 at this point, so this message can never be displayed.
>
> Remove it.
>
> Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver")
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> HOWEVER, the message is about 'clk_set_rate_range()', not
> 'clk_hw_set_rate_range()'. So the message is maybe correct and the
> 'xxx_rate_range()' function incorrect.
> ---
> drivers/clk/zynqmp/pll.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/zynqmp/pll.c b/drivers/clk/zynqmp/pll.c
> index abe6afbf3407..af11e9400058 100644
> --- a/drivers/clk/zynqmp/pll.c
> +++ b/drivers/clk/zynqmp/pll.c
> @@ -331,8 +331,6 @@ struct clk_hw *zynqmp_clk_register_pll(const char *name,
> u32 clk_id,
> }
>
> clk_hw_set_rate_range(hw, PS_PLL_VCO_MIN, PS_PLL_VCO_MAX);
> - if (ret < 0)
> - pr_err("%s:ERROR clk_set_rate_range failed %d\n", name, ret);
[Rajan] Instead of removing, can we get return value of clk_hw_set_rate_range() and
print in case of an error.

>
> return hw;
> }
> --
> 2.30.2

2021-05-03 05:55:54

by Christophe JAILLET

Subject: Re: [PATCH] clk: zynqmp: pll: Remove some dead code

Le 03/05/2021 à 06:56, Rajan Vaja a écrit :
> Hi,
>
> Thanks for the patch.
>
>> -----Original Message-----
>> From: Christophe JAILLET <[email protected]>
>> Sent: 01 May 2021 04:55 PM
>> To: [email protected]; [email protected]; Michal Simek
>> <[email protected]>; [email protected]; Rajan Vaja
>> <[email protected]>; Jolly Shah <[email protected]>; Tejas Patel
>> <[email protected]>; Shubhrajyoti Datta <[email protected]>
>> Cc: [email protected]; [email protected]; linux-
>> [email protected]; [email protected]; Christophe JAILLET
>> <[email protected]>
>> Subject: [PATCH] clk: zynqmp: pll: Remove some dead code
>>
>> 'clk_hw_set_rate_range()' does not return any error code and 'ret' is
>> known to be 0 at this point, so this message can never be displayed.
>>
>> Remove it.
>>
>> Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver")
>> Signed-off-by: Christophe JAILLET <[email protected]>
>> ---
>> HOWEVER, the message is about 'clk_set_rate_range()', not
>> 'clk_hw_set_rate_range()'. So the message is maybe correct and the
>> 'xxx_rate_range()' function incorrect.
>> ---
>> drivers/clk/zynqmp/pll.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/clk/zynqmp/pll.c b/drivers/clk/zynqmp/pll.c
>> index abe6afbf3407..af11e9400058 100644
>> --- a/drivers/clk/zynqmp/pll.c
>> +++ b/drivers/clk/zynqmp/pll.c
>> @@ -331,8 +331,6 @@ struct clk_hw *zynqmp_clk_register_pll(const char *name,
>> u32 clk_id,
>> }
>>
>> clk_hw_set_rate_range(hw, PS_PLL_VCO_MIN, PS_PLL_VCO_MAX);
>> - if (ret < 0)
>> - pr_err("%s:ERROR clk_set_rate_range failed %d\n", name, ret);
> [Rajan] Instead of removing, can we get return value of clk_hw_set_rate_range() and
> print in case of an error.

Hi,

if it was possible, it is what I would have proposed because it looks
'logical'.

However, 'clk_hw_set_rate_range()' returns void.
Hence my comment about 'clk_hw_set_rate_range' being the correct
function to call or not. (i.e. is the comment right and
'clk_hw_set_rate_range' wrong?)

CJ



>> return hw;
>> }
>> --
>> 2.30.2

2021-05-05 11:59:21

by Rajan Vaja

Subject: RE: [PATCH] clk: zynqmp: pll: Remove some dead code

Hi Chris,

> -----Original Message-----
> From: Christophe JAILLET <[email protected]>
> Sent: 03 May 2021 11:20 AM
> To: Rajan Vaja <[email protected]>; [email protected];
> [email protected]; Michal Simek <[email protected]>;
> [email protected]; Jolly Shah <[email protected]>; Tejas Patel
> <[email protected]>; Shubhrajyoti Datta <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Subject: Re: [PATCH] clk: zynqmp: pll: Remove some dead code
>
>
> Le 03/05/2021 à 06:56, Rajan Vaja a écrit :
> > Hi,
> >
> > Thanks for the patch.
> >
> >> -----Original Message-----
> >> From: Christophe JAILLET <[email protected]>
> >> Sent: 01 May 2021 04:55 PM
> >> To: [email protected]; [email protected]; Michal Simek
> >> <[email protected]>; [email protected]; Rajan Vaja
> >> <[email protected]>; Jolly Shah <[email protected]>; Tejas Patel
> >> <[email protected]>; Shubhrajyoti Datta <[email protected]>
> >> Cc: [email protected]; [email protected]; linux-
> >> [email protected]; [email protected]; Christophe JAILLET
> >> <[email protected]>
> >> Subject: [PATCH] clk: zynqmp: pll: Remove some dead code
> >>
> >> 'clk_hw_set_rate_range()' does not return any error code and 'ret' is
> >> known to be 0 at this point, so this message can never be displayed.
> >>
> >> Remove it.
> >>
> >> Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver")
> >> Signed-off-by: Christophe JAILLET <[email protected]>
> >> ---
> >> HOWEVER, the message is about 'clk_set_rate_range()', not
> >> 'clk_hw_set_rate_range()'. So the message is maybe correct and the
> >> 'xxx_rate_range()' function incorrect.
> >> ---
> >> drivers/clk/zynqmp/pll.c | 2 --
> >> 1 file changed, 2 deletions(-)
> >>
> >> diff --git a/drivers/clk/zynqmp/pll.c b/drivers/clk/zynqmp/pll.c
> >> index abe6afbf3407..af11e9400058 100644
> >> --- a/drivers/clk/zynqmp/pll.c
> >> +++ b/drivers/clk/zynqmp/pll.c
> >> @@ -331,8 +331,6 @@ struct clk_hw *zynqmp_clk_register_pll(const char
> *name,
> >> u32 clk_id,
> >> }
> >>
> >> clk_hw_set_rate_range(hw, PS_PLL_VCO_MIN, PS_PLL_VCO_MAX);
> >> - if (ret < 0)
> >> - pr_err("%s:ERROR clk_set_rate_range failed %d\n", name, ret);
> > [Rajan] Instead of removing, can we get return value of clk_hw_set_rate_range()
> and
> > print in case of an error.
>
> Hi,
>
> if it was possible, it is what I would have proposed because it looks
> 'logical'.
>
> However, 'clk_hw_set_rate_range()' returns void.
> Hence my comment about 'clk_hw_set_rate_range' being the correct
> function to call or not. (i.e. is the comment right and
> 'clk_hw_set_rate_range' wrong?)
[Rajan] Thanks for the clarification. Then, it looks fine.

>
> CJ
>
>
>
> >> return hw;
> >> }
> >> --
> >> 2.30.2

2021-05-07 12:25:01

by Michael Tretter

Subject: Re: [PATCH] clk: zynqmp: pll: Remove some dead code

On Sat, 01 May 2021 13:24:32 +0200, Christophe JAILLET wrote:
> 'clk_hw_set_rate_range()' does not return any error code and 'ret' is
> known to be 0 at this point, so this message can never be displayed.
>
> Remove it.
>
> Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver")
> Signed-off-by: Christophe JAILLET <[email protected]>

Reviewed-by: Michael Tretter <[email protected]>

> ---
> HOWEVER, the message is about 'clk_set_rate_range()', not
> 'clk_hw_set_rate_range()'. So the message is maybe correct and the
> 'xxx_rate_range()' function incorrect.

Thanks. The function is correct, as this is a clock provider and should use
the clk_hw. Removing the message is correct.

Michael

> ---
> drivers/clk/zynqmp/pll.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/zynqmp/pll.c b/drivers/clk/zynqmp/pll.c
> index abe6afbf3407..af11e9400058 100644
> --- a/drivers/clk/zynqmp/pll.c
> +++ b/drivers/clk/zynqmp/pll.c
> @@ -331,8 +331,6 @@ struct clk_hw *zynqmp_clk_register_pll(const char *name, u32 clk_id,
> }
>
> clk_hw_set_rate_range(hw, PS_PLL_VCO_MIN, PS_PLL_VCO_MAX);
> - if (ret < 0)
> - pr_err("%s:ERROR clk_set_rate_range failed %d\n", name, ret);
>
> return hw;
> }
> --
> 2.30.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

2021-06-25 23:11:04

by Stephen Boyd

Subject: Re: [PATCH] clk: zynqmp: pll: Remove some dead code

Quoting Christophe JAILLET (2021-05-01 04:24:32)
> 'clk_hw_set_rate_range()' does not return any error code and 'ret' is
> known to be 0 at this point, so this message can never be displayed.
>
> Remove it.
>
> Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver")
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---

Applied to clk-next