2021-07-13 18:41:57

by Brijesh Singh

[permalink] [raw]
Subject: Re: [PATCH 3/3] KVM, SEV: Add support for SEV-ES local migration



On 6/21/21 11:31 AM, Peter Gonda wrote:

> @@ -1196,8 +1299,19 @@ static int sev_local_send(struct kvm *kvm, struct kvm_sev_cmd *argp)
> INIT_LIST_HEAD(&entry->regions_list);
> list_replace_init(&sev->regions_list, &entry->regions_list);
>
> + if (sev_es_guest(kvm)) {
> + /*
> + * If this is an ES guest, we need to move each VMCB's VMSA into a
> + * list for migration.
> + */
> + entry->es_enabled = true;
> + entry->ap_jump_table = sev->ap_jump_table;
> + if (create_vmsa_list(kvm, entry))
> + goto e_listdel;
> + }
> +

the patch looks good. Similar to the previous patch, do we need to check
for the SEV guest state >= LAUNCH_UPDATE to be sure that VMSA's are
encrypted before we go about sharing it with the new VMM ?

-Brijesh