LinuxLists.cc - [PATCH 01/30] thermal: cpu_cooling: remove unused headers

2013-04-17 17:13:23

Subject: [PATCH 01/30] thermal: cpu_cooling: remove unused headers

As this code is not a module nor a platform device driver,
this patch removes some unused header files.

Cc: Zhang Rui <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Eduardo Valentin <[email protected]>
---
drivers/thermal/cpu_cooling.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 5f5c780..778c43d 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -20,10 +20,7 @@
*
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
*/
-#include <linux/kernel.h>
-#include <linux/module.h>
#include <linux/thermal.h>
-#include <linux/platform_device.h>
#include <linux/cpufreq.h>
#include <linux/err.h>
#include <linux/slab.h>
--
1.8.2.1.342.gfa7285d

2013-04-22 02:16:28

by amit daniel kachhap

[permalink] [raw]

Subject: Re: [PATCH 01/30] thermal: cpu_cooling: remove unused headers

Hi,

On Wed, Apr 17, 2013 at 10:41 PM, Eduardo Valentin
<[email protected]> wrote:
> As this code is not a module nor a platform device driver,
> this patch removes some unused header files.
>
> Cc: Zhang Rui <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Eduardo Valentin <[email protected]>

Reviewed-by: Amit Daniel Kachhap<[email protected]>

Thanks,
Amit Daniel
> ---
> drivers/thermal/cpu_cooling.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 5f5c780..778c43d 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -20,10 +20,7 @@
> *
> * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> */
> -#include <linux/kernel.h>
> -#include <linux/module.h>
> #include <linux/thermal.h>
> -#include <linux/platform_device.h>
> #include <linux/cpufreq.h>
> #include <linux/err.h>
> #include <linux/slab.h>
> --
> 1.8.2.1.342.gfa7285d
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2013-04-24 14:44:31

by Zhang, Rui

[permalink] [raw]

Subject: RE: [PATCH 01/30] thermal: cpu_cooling: remove unused headers

2013-04-24 16:32:47

by Zhang, Rui

[permalink] [raw]

Subject: RE: [PATCH 01/30] thermal: cpu_cooling: remove unused headers

> -----Original Message-----
> From: [email protected] [mailto:linux-pm-
> [email protected]] On Behalf Of Eduardo Valentin
> Sent: Thursday, April 18, 2013 1:12 AM
> To: [email protected]
> Cc: Eduardo Valentin; Zhang, Rui; [email protected]; linux-
> [email protected]
> Subject: [PATCH 01/30] thermal: cpu_cooling: remove unused headers
> Importance: High
>
> As this code is not a module nor a platform device driver, this patch
> removes some unused header files.
>
> Cc: Zhang Rui <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Eduardo Valentin <[email protected]>
> ---
> drivers/thermal/cpu_cooling.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c
> b/drivers/thermal/cpu_cooling.c index 5f5c780..778c43d 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -20,10 +20,7 @@
> *
> *
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~
> */
> -#include <linux/kernel.h>
> -#include <linux/module.h>

This is still needed because of EXPORT_SYMBOL.
Or else, I get:
drivers/thermal/cpu_cooling.c:225:1: warning: data definition has no type or storage class [enabled by default]
drivers/thermal/cpu_cooling.c:225:1: warning: type defaults to int in declaration of EXPORT_SYMBOL_GPL [-Wimplicit-int]
drivers/thermal/cpu_cooling.c:225:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/thermal/cpu_cooling.c:479:1: warning: data definition has no type or storage class [enabled by default]
drivers/thermal/cpu_cooling.c:479:1: warning: type defaults to int in declaration of EXPORT_SYMBOL_GPL [-Wimplicit-int]
drivers/thermal/cpu_cooling.c:479:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/thermal/cpu_cooling.c:505:1: warning: data definition has no type or storage class [enabled by default]
drivers/thermal/cpu_cooling.c:505:1: warning: type defaults to int in declaration of EXPORT_SYMBOL_GPL [-Wimplicit-int]
drivers/thermal/cpu_cooling.c:505:1: warning: parameter names (without types) in function declaration [enabled by default]

thanks,
rui

> #include <linux/thermal.h>
> -#include <linux/platform_device.h>
> #include <linux/cpufreq.h>
> #include <linux/err.h>
> #include <linux/slab.h>
> --
> 1.8.2.1.342.gfa7285d
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to [email protected] More majordomo info
> at http://vger.kernel.org/majordomo-info.html

2013-04-24 16:39:51

by Zhang, Rui

[permalink] [raw]

Subject: RE: [PATCH 01/30] thermal: cpu_cooling: remove unused headers

> -----Original Message-----
> From: [email protected] [mailto:linux-pm-
> [email protected]] On Behalf Of Zhang, Rui
> Sent: Thursday, April 25, 2013 12:32 AM
> To: Eduardo Valentin; [email protected]
> Cc: [email protected]; [email protected]
> Subject: RE: [PATCH 01/30] thermal: cpu_cooling: remove unused headers
>
>
>
> > -----Original Message-----
> > From: [email protected] [mailto:linux-pm-
> > [email protected]] On Behalf Of Eduardo Valentin
> > Sent: Thursday, April 18, 2013 1:12 AM
> > To: [email protected]
> > Cc: Eduardo Valentin; Zhang, Rui; [email protected]; linux-
> > [email protected]
> > Subject: [PATCH 01/30] thermal: cpu_cooling: remove unused headers
> > Importance: High
> >
> > As this code is not a module nor a platform device driver, this patch
> > removes some unused header files.
> >
> > Cc: Zhang Rui <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Signed-off-by: Eduardo Valentin <[email protected]>
> > ---
> > drivers/thermal/cpu_cooling.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/thermal/cpu_cooling.c
> > b/drivers/thermal/cpu_cooling.c index 5f5c780..778c43d 100644
> > --- a/drivers/thermal/cpu_cooling.c
> > +++ b/drivers/thermal/cpu_cooling.c
> > @@ -20,10 +20,7 @@
> > *
> > *
> >
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ~
> > ~~~
> > */
> > -#include <linux/kernel.h>
> > -#include <linux/module.h>
>
> This is still needed because of EXPORT_SYMBOL.
> Or else, I get:
> drivers/thermal/cpu_cooling.c:225:1: warning: data definition has no
> type or storage class [enabled by default]
> drivers/thermal/cpu_cooling.c:225:1: warning: type defaults to int in
> declaration of EXPORT_SYMBOL_GPL [-Wimplicit-int]
> drivers/thermal/cpu_cooling.c:225:1: warning: parameter names (without
> types) in function declaration [enabled by default]
> drivers/thermal/cpu_cooling.c:479:1: warning: data definition has no
> type or storage class [enabled by default]
> drivers/thermal/cpu_cooling.c:479:1: warning: type defaults to int in
> declaration of EXPORT_SYMBOL_GPL [-Wimplicit-int]
> drivers/thermal/cpu_cooling.c:479:1: warning: parameter names (without
> types) in function declaration [enabled by default]
> drivers/thermal/cpu_cooling.c:505:1: warning: data definition has no
> type or storage class [enabled by default]
> drivers/thermal/cpu_cooling.c:505:1: warning: type defaults to int in
> declaration of EXPORT_SYMBOL_GPL [-Wimplicit-int]
> drivers/thermal/cpu_cooling.c:505:1: warning: parameter names (without
> types) in function declaration [enabled by default]
>
Patch refreshed with keeping "#include <linux/module.h>" and applied.

> thanks,
> rui
>
> > #include <linux/thermal.h>
> > -#include <linux/platform_device.h>
> > #include <linux/cpufreq.h>
> > #include <linux/err.h>
> > #include <linux/slab.h>
> > --
> > 1.8.2.1.342.gfa7285d
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-pm"
> in
> > the body of a message to [email protected] More majordomo
> info
> > at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to [email protected] More majordomo info
> at http://vger.kernel.org/majordomo-info.html