2022-08-09 21:44:14

by Christophe JAILLET

Subject: [PATCH v2] usb: common: usb-conn-gpio: Simplify some error message

dev_err_probe() already prints the error code in a human readable way, so
there is no need to duplicate it as a numerical value at the end of the
message.

Fixes: ddaf0d6dc467 ("usb: common: usb-conn-gpio: use dev_err_probe() to print log")
Signed-off-by: Christophe JAILLET <[email protected]>
---
Change in v2:
* keep the message on the same line of dev_err_probe() because the line is
still < 100 char [Chunfeng Yun <[email protected]>]
---
drivers/usb/common/usb-conn-gpio.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/common/usb-conn-gpio.c b/drivers/usb/common/usb-conn-gpio.c
index b39c9f1c375d..44c5127175b7 100644
--- a/drivers/usb/common/usb-conn-gpio.c
+++ b/drivers/usb/common/usb-conn-gpio.c
@@ -208,10 +208,8 @@ static int usb_conn_probe(struct platform_device *pdev)
if (PTR_ERR(info->vbus) == -ENODEV)
info->vbus = NULL;

- if (IS_ERR(info->vbus)) {
- ret = PTR_ERR(info->vbus);
- return dev_err_probe(dev, ret, "failed to get vbus :%d\n", ret);
- }
+ if (IS_ERR(info->vbus))
+ return dev_err_probe(dev, PTR_ERR(info->vbus), "failed to get vbus\n");

info->role_sw = usb_role_switch_get(dev);
if (IS_ERR(info->role_sw))
--
2.34.1

2022-08-11 07:51:19

by Chunfeng Yun

Subject: Re: [PATCH v2] usb: common: usb-conn-gpio: Simplify some error message

On Tue, 2022-08-09 at 22:28 +0200, Christophe JAILLET wrote:
> dev_err_probe() already prints the error code in a human readable
> way, so
> there is no need to duplicate it as a numerical value at the end of
> the
> message.
>
> Fixes: ddaf0d6dc467 ("usb: common: usb-conn-gpio: use dev_err_probe()
> to print log")
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> Change in v2:
> * keep the message on the same line of dev_err_probe() because the
> line is
> still < 100 char [Chunfeng Yun <[email protected]>]
> ---
> drivers/usb/common/usb-conn-gpio.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/common/usb-conn-gpio.c
> b/drivers/usb/common/usb-conn-gpio.c
> index b39c9f1c375d..44c5127175b7 100644
> --- a/drivers/usb/common/usb-conn-gpio.c
> +++ b/drivers/usb/common/usb-conn-gpio.c
> @@ -208,10 +208,8 @@ static int usb_conn_probe(struct platform_device
> *pdev)
> if (PTR_ERR(info->vbus) == -ENODEV)
> info->vbus = NULL;
>
> - if (IS_ERR(info->vbus)) {
> - ret = PTR_ERR(info->vbus);
> - return dev_err_probe(dev, ret, "failed to get vbus
> :%d\n", ret);
> - }
> + if (IS_ERR(info->vbus))
> + return dev_err_probe(dev, PTR_ERR(info->vbus), "failed
> to get vbus\n");
>
> info->role_sw = usb_role_switch_get(dev);
> if (IS_ERR(info->role_sw))
Reviewed-by: Chunfeng Yun <[email protected]>

Thanks