2021-05-12 20:40:05

by Randy Dunlap

Subject: Re: linux-next: Tree for May 12 (arch/x86/net/bpf_jit_comp32.o)

On 5/12/21 11:53 AM, Daniel Borkmann wrote:
> Hi Randy,
>
> On 5/12/21 8:01 PM, Randy Dunlap wrote:
>> On 5/12/21 12:56 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20210511:
>>>
>>
>> on i386:
>>
>> ld: arch/x86/net/bpf_jit_comp32.o: in function `do_jit':
>> bpf_jit_comp32.c:(.text+0x28c9): undefined reference to `__bpf_call_base'
>> ld: arch/x86/net/bpf_jit_comp32.o: in function `bpf_int_jit_compile':
>> bpf_jit_comp32.c:(.text+0x3694): undefined reference to `bpf_jit_blind_constants'
>> ld: bpf_jit_comp32.c:(.text+0x3719): undefined reference to `bpf_jit_binary_free'
>> ld: bpf_jit_comp32.c:(.text+0x3745): undefined reference to `bpf_jit_binary_alloc'
>> ld: bpf_jit_comp32.c:(.text+0x37d3): undefined reference to `bpf_jit_prog_release_other'
>> ld: kernel/extable.o: in function `search_exception_tables':
>> extable.c:(.text+0x42): undefined reference to `search_bpf_extables'
>> ld: kernel/extable.o: in function `kernel_text_address':
>> extable.c:(.text+0xee): undefined reference to `is_bpf_text_address'
>> ld: kernel/kallsyms.o: in function `kallsyms_lookup_size_offset':
>> kallsyms.c:(.text+0x254): undefined reference to `__bpf_address_lookup'
>> ld: kernel/kallsyms.o: in function `kallsyms_lookup_buildid':
>> kallsyms.c:(.text+0x2ee): undefined reference to `__bpf_address_lookup'
>
> Thanks for reporting, could you double check the following diff:
>
> diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
> index 26b591e23f16..bd04f4a44c01 100644
> --- a/kernel/bpf/Kconfig
> +++ b/kernel/bpf/Kconfig
> @@ -37,6 +37,7 @@ config BPF_SYSCALL
>
> config BPF_JIT
>     bool "Enable BPF Just In Time compiler"
> +    depends on BPF
>     depends on HAVE_CBPF_JIT || HAVE_EBPF_JIT
>     depends on MODULES
>     help

That's good. Thanks.

Acked-by: Randy Dunlap <[email protected]> # build-tested


--
~Randy

2021-05-12 20:53:13

by Daniel Borkmann

Subject: Re: linux-next: Tree for May 12 (arch/x86/net/bpf_jit_comp32.o)

On 5/12/21 9:26 PM, Randy Dunlap wrote:
> On 5/12/21 11:53 AM, Daniel Borkmann wrote:
>> On 5/12/21 8:01 PM, Randy Dunlap wrote:
>>> On 5/12/21 12:56 AM, Stephen Rothwell wrote:
>>> on i386:
>>>
>>> ld: arch/x86/net/bpf_jit_comp32.o: in function `do_jit':
>>> bpf_jit_comp32.c:(.text+0x28c9): undefined reference to `__bpf_call_base'
>>> ld: arch/x86/net/bpf_jit_comp32.o: in function `bpf_int_jit_compile':
>>> bpf_jit_comp32.c:(.text+0x3694): undefined reference to `bpf_jit_blind_constants'
>>> ld: bpf_jit_comp32.c:(.text+0x3719): undefined reference to `bpf_jit_binary_free'
>>> ld: bpf_jit_comp32.c:(.text+0x3745): undefined reference to `bpf_jit_binary_alloc'
>>> ld: bpf_jit_comp32.c:(.text+0x37d3): undefined reference to `bpf_jit_prog_release_other'
>>> ld: kernel/extable.o: in function `search_exception_tables':
>>> extable.c:(.text+0x42): undefined reference to `search_bpf_extables'
>>> ld: kernel/extable.o: in function `kernel_text_address':
>>> extable.c:(.text+0xee): undefined reference to `is_bpf_text_address'
>>> ld: kernel/kallsyms.o: in function `kallsyms_lookup_size_offset':
>>> kallsyms.c:(.text+0x254): undefined reference to `__bpf_address_lookup'
>>> ld: kernel/kallsyms.o: in function `kallsyms_lookup_buildid':
>>> kallsyms.c:(.text+0x2ee): undefined reference to `__bpf_address_lookup'
>>
>> Thanks for reporting, could you double check the following diff:
>>
>> diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
>> index 26b591e23f16..bd04f4a44c01 100644
>> --- a/kernel/bpf/Kconfig
>> +++ b/kernel/bpf/Kconfig
>> @@ -37,6 +37,7 @@ config BPF_SYSCALL
>>
>> config BPF_JIT
>>     bool "Enable BPF Just In Time compiler"
>> +    depends on BPF
>>     depends on HAVE_CBPF_JIT || HAVE_EBPF_JIT
>>     depends on MODULES
>>     help
>
> That's good. Thanks.

Thanks, pushed fix to bpf tree.