2021-06-15 15:57:18

by Aswath Govindraju

[permalink] [raw]
Subject: [PATCH v3 0/3] AM64: Update the locations of various elements in SRAM

The following series of patches,
- Increase the maximum size of TF-A
- Update the location of TF-A due to a limitation for DFU boot
- Indicate reserved locations for DMSC code and secure proxy

changes since v2:
- split the patches into three
- added regions for indicating memory regions reserved for
dmsc and secure proxy
- moved the TFA location to 0x701c4000

Aswath Govindraju (3):
dts: ti: k3-am64-main: Update TF-A's maximum size and node name
arm64: dts: ti: k3-am64-main: Indicate the memory reserved for
DMSC-lite code and secure proxy communication buffer
arm64: dts: ti: k3-am64-main: Update the location of TF-A

arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)

--
2.17.1


2021-06-15 15:57:19

by Aswath Govindraju

[permalink] [raw]
Subject: [PATCH v3 2/3] arm64: dts: ti: k3-am64-main: Indicate the memory reserved for DMSC-lite code and secure proxy communication buffer

The final 128KB in SRAM is reserved by default for DMSC-lite code and
secure proxy communication buffer. The memory region used for DMSC-lite
code can be optionally freed up by secure firmware API[1]. However, the
buffer for secure proxy communication is not configurable. This default
hardware configuration is unique for AM64.

Therefore, indicate the area reserved for DMSC-lite code and secure proxy
communication buffer in the oc_sram device tree node.

[1] - http://downloads.ti.com/tisci/esd/latest/6_topic_user_guides/security_handover.html#triggering-security-handover

Signed-off-by: Aswath Govindraju <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index 693fe24e7f7a..6a883f4349cb 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -27,6 +27,14 @@
tfa-sram@0 {
reg = <0x0 0x1c000>;
};
+
+ dmsc-sram@1e0000 {
+ reg = <0x1e0000 0x1c000>;
+ };
+
+ sproxy-sram@1fc000 {
+ reg = <0x1fc000 0x4000>;
+ };
};

main_conf: syscon@43000000 {
--
2.17.1

2021-06-15 15:57:29

by Aswath Govindraju

[permalink] [raw]
Subject: [PATCH v3 3/3] arm64: dts: ti: k3-am64-main: Update the location of TF-A

Due to a limitation for USB DFU boot mode, SPL load address has to be less
than or equal to 0x70001000. So, load address of SPL and TF-A have been
moved to 0x70000000 and 0x701c4000 respectively.

Therefore, update TF-A's location in the device tree node.

Signed-off-by: Aswath Govindraju <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index 6a883f4349cb..7ab3652dfdfb 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -24,8 +24,8 @@
#size-cells = <1>;
ranges = <0x0 0x00 0x70000000 0x200000>;

- tfa-sram@0 {
- reg = <0x0 0x1c000>;
+ tfa-sram@1c4000 {
+ reg = <0x1c4000 0x1c000>;
};

dmsc-sram@1e0000 {
--
2.17.1

2021-06-15 15:59:44

by Aswath Govindraju

[permalink] [raw]
Subject: [PATCH v3 1/3] dts: ti: k3-am64-main: Update TF-A's maximum size and node name

The maximum size of TF-A 2.5 has been increased to 0x1c000 [1]. Therefore,
update this accordingly in the device tree node.

Also, update the node name to "tfa-sram".

[1] - https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=2fb5312f61a7de8b7a70e1639199c4f14a10b6f9

Signed-off-by: Aswath Govindraju <[email protected]>
Reviewed-by: Suman Anna <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index dec54243f454..693fe24e7f7a 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -24,8 +24,8 @@
#size-cells = <1>;
ranges = <0x0 0x00 0x70000000 0x200000>;

- atf-sram@0 {
- reg = <0x0 0x1a000>;
+ tfa-sram@0 {
+ reg = <0x0 0x1c000>;
};
};

--
2.17.1

2021-06-15 16:24:18

by Suman Anna

[permalink] [raw]
Subject: Re: [PATCH v3 1/3] dts: ti: k3-am64-main: Update TF-A's maximum size and node name

On 6/15/21 10:51 AM, Aswath Govindraju wrote:
> The maximum size of TF-A 2.5 has been increased to 0x1c000 [1]. Therefore,
> update this accordingly in the device tree node.
>
> Also, update the node name to "tfa-sram".
>
> [1] - https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=2fb5312f61a7de8b7a70e1639199c4f14a10b6f9
>
> Signed-off-by: Aswath Govindraju <[email protected]>
> Reviewed-by: Suman Anna <[email protected]>

Patch title should start with arm64: following the standard convention.
Sorry missed this in the prior review. Otherwise, everything LGTM.

regards
Suman

> ---
> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index dec54243f454..693fe24e7f7a 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -24,8 +24,8 @@
> #size-cells = <1>;
> ranges = <0x0 0x00 0x70000000 0x200000>;
>
> - atf-sram@0 {
> - reg = <0x0 0x1a000>;
> + tfa-sram@0 {
> + reg = <0x0 0x1c000>;
> };
> };
>
>

2021-06-15 17:49:06

by Aswath Govindraju

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] AM64: Update the locations of various elements in SRAM

Hi,
On 15/06/21 9:21 pm, Aswath Govindraju wrote:
> The following series of patches,
> - Increase the maximum size of TF-A
> - Update the location of TF-A due to a limitation for DFU boot
> - Indicate reserved locations for DMSC code and secure proxy
>
> changes since v2:
> - split the patches into three
> - added regions for indicating memory regions reserved for
> dmsc and secure proxy
> - moved the TFA location to 0x701c4000
>

Posted respin(v4) after correcting the titles of patches 1 and 2.

Thanks,
Aswath

> Aswath Govindraju (3):
> dts: ti: k3-am64-main: Update TF-A's maximum size and node name
> arm64: dts: ti: k3-am64-main: Indicate the memory reserved for
> DMSC-lite code and secure proxy communication buffer
> arm64: dts: ti: k3-am64-main: Update the location of TF-A
>
> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>